Skip to content

[gpt-oss][2] fix types for streaming #24556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

[gpt-oss][2] fix types for streaming #24556

merged 2 commits into from
Sep 17, 2025

Conversation

@qandrew
Copy link
Contributor

@qandrew qandrew commented Sep 10, 2025 •
edited by github-actions bot
Loading

Purpose

there is no logic changes in this PR, only type changes.

  • create a type StreamingResponsesResponses which is the union of all possible outputs of stream in ResponsesAPI. This should be very helpful for downstream users.
  • some code clean up

Test Plan

unit tests pass

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added frontend gpt-oss Related to GPT-OSS models labels Sep 10, 2025
@facebook-github-bot
Copy link

@qandrew has imported this pull request. If you are a Meta employee, you can view this in D82121376.

@qandrew qandrew force-pushed the andrew/gpt-oss-streaming-2 branch from d7aa113 to 7c642b0 Compare September 10, 2025 16:12
@facebook-github-bot
Copy link

@qandrew has imported this pull request. If you are a Meta employee, you can view this in D82121376.

@qandrew qandrew mentioned this pull request Sep 10, 2025
Merged
5 tasks
@mergify
Copy link

mergify bot commented Sep 16, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @qandrew.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 16, 2025
@qandrew
initial commit replace basemodel types
e8fa50f 
Signed-off-by: Andrew Xia <axia@meta.com>
@qandrew qandrew force-pushed the andrew/gpt-oss-streaming-2 branch from 7c642b0 to e8fa50f Compare September 16, 2025 20:06
@mergify mergify bot removed the needs-rebase label Sep 16, 2025
@qandrew qandrew changed the title [gpt-oss][2] fix types [gpt-oss][2] fix types for streaming Sep 16, 2025
@qandrew
fix
efcdeea 
Signed-off-by: Andrew Xia <axia@meta.com>
@qandrew qandrew marked this pull request as ready for review September 16, 2025 20:43
@qandrew
Copy link
Contributor Author

qandrew commented Sep 16, 2025 •
edited
Loading

cc @lacora here's the type updates
cc @houseroad if you could review, thanks!

houseroad
houseroad approved these changes Sep 17, 2025
View reviewed changes
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-project-automation github-project-automation bot moved this from To Triage to Ready in gpt-oss Issues & Enhancements Sep 17, 2025
@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 17, 2025
@houseroad houseroad enabled auto-merge (squash) September 17, 2025 21:33
@houseroad houseroad merged commit bff2e5f into vllm-project:main Sep 17, 2025
56 checks passed
@qandrew qandrew mentioned this pull request Sep 18, 2025
Open
1 task
debroy-rh pushed a commit to debroy-rh/vllm that referenced this pull request Sep 19, 2025
@qandrew @debroy-rh
[gpt-oss][2] fix types for streaming (vllm-project#24556)
cb82e4e 
Signed-off-by: Andrew Xia <axia@meta.com>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@qandrew @FeiDaLI
[gpt-oss][2] fix types for streaming (vllm-project#24556)
44658c7 
Signed-off-by: Andrew Xia <axia@meta.com>
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
@qandrew @charlifu
[gpt-oss][2] fix types for streaming (vllm-project#24556)
156ba2e 
Signed-off-by: Andrew Xia <axia@meta.com>
Signed-off-by: charlifu <charlifu@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@qandrew @xuebwang-amd
[gpt-oss][2] fix types for streaming (vllm-project#24556)
3ffa688 
Signed-off-by: Andrew Xia <axia@meta.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
@qandrew @choprahetarth
[gpt-oss][2] fix types for streaming (vllm-project#24556)
0f03772 
Signed-off-by: Andrew Xia <axia@meta.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@qandrew @xuebwang-amd
[gpt-oss][2] fix types for streaming (vllm-project#24556)
2fea5c9 
Signed-off-by: Andrew Xia <axia@meta.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houseroad houseroad houseroad approved these changes

@aarnphm aarnphm Awaiting requested review from aarnphm aarnphm is a code owner

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang chaunceyjiang is a code owner

Assignees

No one assigned

Labels

frontend gpt-oss Related to GPT-OSS models ready ONLY add when PR is ready to merge/full CI is needed

Projects

gpt-oss Issues & Enhancements
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qandrew @facebook-github-bot @houseroad