Skip to content

Apply fixes for CUDA 13 #24599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 17, 2025
Merged

Apply fixes for CUDA 13 #24599

merged 5 commits into from
Sep 17, 2025
+47 −56

Conversation

@Aidyn-A
Copy link
Contributor

@Aidyn-A Aidyn-A commented Sep 10, 2025 •
edited by github-actions bot
Loading

Purpose

Fixes #24464 "Building vLLM with CUDA 13.0".

Test Plan

No plans. Just build.

Test Result

Test results must be the same as on CUDA 12.x.

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added the ci/build label Sep 10, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 10, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces fixes for building with CUDA 13 by abstracting CUB API differences into a new cub_helpers.h header. The changes are well-implemented and consistently applied across all relevant CUDA kernel files. This is a good approach to handle version-specific API changes. I have one suggestion for CMakeLists.txt to improve the robustness of how compiler flags are added.

atalman
atalman approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ProExpertProg
ProExpertProg reviewed Sep 10, 2025
View reviewed changes
Copy link
Collaborator

@ProExpertProg ProExpertProg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from 1 nit, also Gemini suggestion is good. Did you try to build vLLM from source locally (pip install -e .) with cuda 13.0?

@Aidyn-A
Copy link
Contributor Author

Aidyn-A commented Sep 11, 2025 •
edited
Loading

Did you try to build vLLM from source locally (pip install -e .) with cuda 13.0?

Yes, I did. I ran VLLM_TARGET_DEVICE=cuda pip install --verbose --no-deps --no-build-isolation -e . to confirm it:

$ pip show vllm
Name: vllm
Version: 0.10.2rc2.dev89+gf94619747.d20250911.cu130
...

@Aidyn-A
Apply fixes for CUDA 13
cd9f680 
Signed-off-by: Aidyn-A <aidyn.b.aitzhan@gmail.com>
@Aidyn-A
Apply suggested review comments
a7d515b 
Signed-off-by: Aidyn-A <aidyn.b.aitzhan@gmail.com>
@Aidyn-A
Fix missed code
234c382 
Signed-off-by: Aidyn-A <aidyn.b.aitzhan@gmail.com>
@Aidyn-A
Resolve CMake
8c517e1 
Signed-off-by: Aidyn-A <aidyn.b.aitzhan@gmail.com>
@Aidyn-A
CMakeLists.txt: use VERSION_GREATER_EQUAL
17e8e05 
Signed-off-by: Aidyn-A <aidyn.b.aitzhan@gmail.com>
@pytorch-bot pytorch-bot bot removed the ci/build label Sep 15, 2025
@mergify mergify bot added the ci/build label Sep 15, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 15, 2025

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@zou3519 zou3519 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 15, 2025
@Aidyn-A
Copy link
Contributor Author

Aidyn-A commented Sep 17, 2025

@huydhn, @atalman are you able to merge it?

@zou3519 zou3519 merged commit bfe9380 into vllm-project:main Sep 17, 2025
92 of 93 checks passed
@ProExpertProg ProExpertProg mentioned this pull request Sep 17, 2025
Closed
@huydhn huydhn mentioned this pull request Sep 18, 2025
Closed
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@Aidyn-A @FeiDaLI
Apply fixes for CUDA 13 (vllm-project#24599)
f34fc51 
Signed-off-by: Aidyn-A <aidyn.b.aitzhan@gmail.com>
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
@Aidyn-A @charlifu
Apply fixes for CUDA 13 (vllm-project#24599)
b0b2bc0 
Signed-off-by: Aidyn-A <aidyn.b.aitzhan@gmail.com>
Signed-off-by: charlifu <charlifu@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@Aidyn-A @xuebwang-amd
Apply fixes for CUDA 13 (vllm-project#24599)
f9b39d5 
Signed-off-by: Aidyn-A <aidyn.b.aitzhan@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
@Aidyn-A @choprahetarth
Apply fixes for CUDA 13 (vllm-project#24599)
385eb24 
Signed-off-by: Aidyn-A <aidyn.b.aitzhan@gmail.com>
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Oct 16, 2025
@huydhn @pytorchmergebot
Build vLLM nightly wheels for CUDA 13.0 (#163239)
c2bd41a 
Now that vllm-project/vllm#24599 has been merged
Pull Request resolved: #163239
Approved by: https://github.com/malfet, https://github.com/atalman
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@huydhn @Chao1Han
Build vLLM nightly wheels for CUDA 13.0 (pytorch#163239)
29581b0 
Now that vllm-project/vllm#24599 has been merged
Pull Request resolved: pytorch#163239
Approved by: https://github.com/malfet, https://github.com/atalman
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@Aidyn-A @xuebwang-amd
Apply fixes for CUDA 13 (vllm-project#24599)
87bf5bf 
Signed-off-by: Aidyn-A <aidyn.b.aitzhan@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@LucasWilkinson LucasWilkinson Awaiting requested review from LucasWilkinson LucasWilkinson is a code owner

@ProExpertProg ProExpertProg Awaiting requested review from ProExpertProg

+2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@atalman atalman atalman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Building vLLM with CUDA 13.0

4 participants

@Aidyn-A @zou3519 @atalman @ProExpertProg