-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[Qwen][ROCm] Flash Attention Rotary Embeddings #24642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
|
@DarkLight1337 would appreciate if you can review. |
| import importlib | ||
| from functools import cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you reorganize the imports to be in the correct order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is ordered using isort. Arranging it alphabetically causes isort to complain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm weird, I thought isort would put it with the rest of the stdlib imports near L5
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Head branch was pushed to by a user without write access
|
@DarkLight1337 @vllmellm , I found this PR introduced a bug to non_cuda/non_rocm, may you take a look of the fixing I provided here: |
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
…d by vllm-project#24642 (vllm-project#26123) Signed-off-by: Chendi Xue <Chendi.Xue@intel.com> Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Co-authored-by: Roger Wang <hey@rogerw.io>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
…d by vllm-project#24642 (vllm-project#26123) Signed-off-by: Chendi Xue <Chendi.Xue@intel.com> Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Co-authored-by: Roger Wang <hey@rogerw.io>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com> Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
…d by vllm-project#24642 (vllm-project#26123) Signed-off-by: Chendi Xue <Chendi.Xue@intel.com> Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Co-authored-by: Roger Wang <hey@rogerw.io> Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
…d by vllm-project#24642 (vllm-project#26123) Signed-off-by: Chendi Xue <Chendi.Xue@intel.com> Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Co-authored-by: Roger Wang <hey@rogerw.io> Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
…d by vllm-project#24642 (vllm-project#26123) Signed-off-by: Chendi Xue <Chendi.Xue@intel.com> Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Co-authored-by: Roger Wang <hey@rogerw.io>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…d by vllm-project#24642 (vllm-project#26123) Signed-off-by: Chendi Xue <Chendi.Xue@intel.com> Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Co-authored-by: Roger Wang <hey@rogerw.io> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
…d by vllm-project#24642 (vllm-project#26123) Signed-off-by: Chendi Xue <Chendi.Xue@intel.com> Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Co-authored-by: Roger Wang <hey@rogerw.io>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
…d by vllm-project#24642 (vllm-project#26123) Signed-off-by: Chendi Xue <Chendi.Xue@intel.com> Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Co-authored-by: Roger Wang <hey@rogerw.io>
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…d by vllm-project#24642 (vllm-project#26123) Signed-off-by: Chendi Xue <Chendi.Xue@intel.com> Signed-off-by: Chendi.Xue <chendi.xue@intel.com> Co-authored-by: Roger Wang <hey@rogerw.io> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
Qwen VL models previously relied on a basic PyTorch implementation for applying rotary positional embeddings on ROCm architectures. This PR adds a ROCm specialisation to use flash_attn module's Triton-based operation which makes it much faster as seen in the benchmarking results below:
benchmark_serving script
Test Plan
Evaluate accuracy with mistral-eval using chartqa dataset on Qwen2.5-VL-7B-Instruct and Qwen2-VL-7B-Instruct
Test Result
Qwen2.5-VL-7B-Instruct-Before
Qwen2-VL-7B-Instruct-Before
Qwen2.5-VL-7B-Instruct-After
Qwen2-VL-7B-Instruct-After
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.