-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
relax pydantic version to '>=1.9.0,<3' #2468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@zhuohan123 this should be ready as a replacement PR for #2322. if the original author shows up again, feel free to close this one. just wanted to get this rolling since multiple people expressed it as a blocker for them |
|
@jvmncs Thanks for your contribution! Can you make sure the CI is passing? |
|
@jvmncs Can you help double check the code? The openAI server is not working on my side. When I install and query the server with: I got this on the server side: and this from the client side: I believe this is also why the CI is failing. Tag more people to see whether there is a solution here: @saattrupdan @dbuades @rlouf |
|
I spent some time debugging this yesterday. my suspicion for now is that openai-python might be changing how they structure the request based on which pydantic version is installed, which is somewhat suggested by this compat utility they wrote. haven't had time to get to the bottom of it though |
|
okay I'm about 90% sure this is the case. using the v2 models in openai protocol got 2 of the failing tests to pass, the other two (streaming tests) now have pydantic validation errors. investigating those shortly |
|
Thanks for looking into this! I'll check it too this weekend. |
|
Thank you for your contribution. I will close this in favor of #2531 |
closes #1396
closes #2313
closes #2322
relaxes the pydantic version, which was previously pinned to 1.10.13 due to openai-python's dependency requirements. since openai has loosened their requirement, vllm should as well.
this is a retry of #2322. that PR has gotten a bit stale after the openai refactor, and there's been no communication from the author for a couple weeks