-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[gpt-oss][1b] streaming add item id, content id #24788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gpt-oss][1b] streaming add item id, content id #24788
Conversation
Signed-off-by: Andrew Xia <axia@meta.com>
4beb7e5 to
e366b57
Compare
d2fd245 to
f2bf243
Compare
| ) | ||
|
|
||
| current_item_id = "" | ||
| current_content_index = -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test case doesn't capture multiple subsequent streaming items?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm i'm not sure if i understand your question? I haven't enabled the tool calling for streaming yet, so currently we're only testing reasoningOutput -> finalOutput items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a sample response from the OpenAI online service?
yep, added in the description |
Signed-off-by: Andrew Xia <axia@meta.com>
Signed-off-by: Andrew Xia <axia@meta.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks~
It looks consistent with OpenAI’s format.
Signed-off-by: Andrew Xia <axia@meta.com>
Signed-off-by: Andrew Xia <axia@meta.com> Signed-off-by: charlifu <charlifu@amd.com>
Signed-off-by: Andrew Xia <axia@meta.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: Andrew Xia <axia@meta.com>
Signed-off-by: Andrew Xia <axia@meta.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
Test Plan
Test Result
Note: the item id, content_index changes as expected
...
OAI example:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.