[Chore] Remove unused batched RoPE op & kernel #24789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
WoosukKwon
requested review from
tlrmchlsmth and
yewentao256
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively removes the unused batched_rotary_embedding operation and its associated kernel. The changes are comprehensive, covering the C++ implementation, Python bindings, and corresponding tests, leading to a cleaner and more maintainable codebase. I have a few minor suggestions to improve code formatting for better readability and consistency with standard Python style guides.
jeejeelee
approved these changes
Sep 13, 2025
dsxsteven
pushed a commit
to dsxsteven/vllm_splitPR
that referenced
this pull request
Sep 15, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Sep 15, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu> Signed-off-by: bbartels <benjamin@bartels.dev>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIUC, batched RoPE is only used when different LoRA adapters have different rope scaling factor.
Now that this feature is dropped in #21169, we can remove this op for simplication.