Skip to content

Conversation

@bbartels
Copy link
Contributor

@bbartels bbartels commented Sep 15, 2025

Purpose

Bumps flashinfer to v0.3.1. Thes version comes with some fixes around certain code paths not being AOT'd.

Test Plan

Run CI checks

Test Result

CI checks passed

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the FlashInfer version to 0.3.1 in the Dockerfile. However, the corresponding dependency in setup.py has not been updated, which will lead to inconsistent versions being installed depending on the environment. This is a critical issue that needs to be addressed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The comment on the preceding line indicates that this version should be synchronized with the flashinfer extra in setup.py. While this file is updated to v0.3.1, setup.py still specifies flashinfer-python==0.3.0. This discrepancy will cause different versions of FlashInfer to be installed depending on whether the project is built using Docker or installed via pip, which can lead to hard-to-debug issues. Please update setup.py to use version 0.3.1 as well.

@mergify mergify bot added the ci/build label Sep 15, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 15, 2025

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@pytorch-bot pytorch-bot bot removed the ci/build label Sep 15, 2025
@mergify mergify bot added the ci/build label Sep 15, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 15, 2025

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

Signed-off-by: bbartels <benjamin@bartels.dev>
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 15, 2025

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 15, 2025
@mgoin
Copy link
Member

mgoin commented Sep 15, 2025

@bbartels Could you please add to the description the reason for the update?

@bbartels
Copy link
Contributor Author

Done @mgoin

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed the blackwell test, LGTM!

@simon-mo simon-mo merged commit 94b03f8 into vllm-project:main Sep 15, 2025
91 of 94 checks passed
tlrmchlsmth pushed a commit to tlrmchlsmth/vllm that referenced this pull request Sep 15, 2025
Signed-off-by: bbartels <benjamin@bartels.dev>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: bbartels <benjamin@bartels.dev>
QierLi pushed a commit to QierLi/vllm that referenced this pull request Oct 5, 2025
Signed-off-by: bbartels <benjamin@bartels.dev>

[gpt-oss] Add IncompleteDetails to ResponsesRepsonse (vllm-project#24561)

Signed-off-by: Andrew Xia <axia@meta.com>

[gpt-oss][1a] create_responses stream outputs BaseModel type, api server is SSE still (vllm-project#24759)

Signed-off-by: Andrew Xia <axia@meta.com>

[Performance] Remove redundant clone() calls in cutlass_mla (vllm-project#24891)

[Bug] Fix Cutlass Scaled MM Compilation Error (vllm-project#24887)

Signed-off-by: yewentao256 <zhyanwentao@126.com>

[ci] fix wheel names for arm wheels (vllm-project#24898)

Signed-off-by: simon-mo <simon.mo@hey.com>

[Tests] fix initialization of kv hash in tests (vllm-project#24273)

Signed-off-by: Mickael Seznec <mickael@mistral.ai>

[Compile] Fix noop_elimination pass and add tests for noop_elimination (vllm-project#24880)

Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>

Propagate entire tokens to connector for resumed preemptions

Signed-off-by: Qier Li <kevin44036@gmail.com>

Fix pre-commit

Signed-off-by: Qier Li <kevin44036@gmail.com>

Rename field and nullify empty lists

Signed-off-by: Qier Li <kevin44036@gmail.com>

Update vllm/v1/core/sched/scheduler.py

Co-authored-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Qier Li <kevin44036@gmail.com>

Add unit test for preemption resumption

Signed-off-by: Qier Li <kevin44036@gmail.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Signed-off-by: bbartels <benjamin@bartels.dev>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
Signed-off-by: bbartels <benjamin@bartels.dev>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: bbartels <benjamin@bartels.dev>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants