-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[gpt-oss] Add ResponseReasoningPartAddedEvent, ResponseReasoningPartDoneEvent for streaming #24938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yeqcharlotte
merged 3 commits into
vllm-project:main
from
qandrew:andrew/gpt-oss-reasoning-part
Sep 19, 2025
Merged
[gpt-oss] Add ResponseReasoningPartAddedEvent, ResponseReasoningPartDoneEvent for streaming #24938
yeqcharlotte
merged 3 commits into
vllm-project:main
from
qandrew:andrew/gpt-oss-reasoning-part
Sep 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
c3f4061 to
71694d7
Compare
Signed-off-by: Andrew Xia <axia@meta.com>
71694d7 to
bad718f
Compare
Contributor
Author
|
cc @yeqcharlotte , @heheda12345 ready for review! |
b39727e to
ed737ab
Compare
yeqcharlotte
approved these changes
Sep 18, 2025
Collaborator
yeqcharlotte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the change!
Collaborator
|
@qandrew test failure is related |
ywang96
pushed a commit
to ywang96/vllm
that referenced
this pull request
Sep 19, 2025
…oneEvent for streaming (vllm-project#24938) Signed-off-by: Andrew Xia <axia@meta.com>
debroy-rh
pushed a commit
to debroy-rh/vllm
that referenced
this pull request
Sep 19, 2025
…oneEvent for streaming (vllm-project#24938) Signed-off-by: Andrew Xia <axia@meta.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…oneEvent for streaming (vllm-project#24938) Signed-off-by: Andrew Xia <axia@meta.com>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
…oneEvent for streaming (vllm-project#24938) Signed-off-by: Andrew Xia <axia@meta.com> Signed-off-by: charlifu <charlifu@amd.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…oneEvent for streaming (vllm-project#24938) Signed-off-by: Andrew Xia <axia@meta.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…oneEvent for streaming (vllm-project#24938) Signed-off-by: Andrew Xia <axia@meta.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…oneEvent for streaming (vllm-project#24938) Signed-off-by: Andrew Xia <axia@meta.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…oneEvent for streaming (vllm-project#24938) Signed-off-by: Andrew Xia <axia@meta.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I noticed that While a ResponseContentPartCreatedEvent is added for reasoning items, ResponseContentPartDoneEvent isn't there. There's actually an underlying issue with openai python package, and I've filed an issue here: openai/openai-python#2634
It seems like the best path forward is to implement ResponseReasoningPartAddedEvent, ResponseReasoningPartDoneEvent in vLLM as oAI may take a while to add to their python library. When that is done, we can remove these types in vLLM.
Test Plan
added a unit test
in addition, we tested manually below:
server
client
results (note response.reasoning_part.added, response.reasoning_part.done)
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.