[ROCm] Add skinny gemm bias support for dtypes fp16,bf16,fp8 #24988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for bias in skinny GEMM kernels for fp16 and bf16 data types. The changes are mostly correct, but there is a critical issue in how the optional bias tensor is handled. The current implementation will fail if None is passed for the bias from Python, and it is also vulnerable to a division-by-zero error if an empty tensor is passed. My review provides a set of fixes to correctly handle the optional bias tensor using c10::optional<at::Tensor>, which involves changes to the op registration, C++ function signatures, and bias handling logic.
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
amd-hhashemi
force-pushed
the
sknyGemmBias
branch
from
87faa59 to
8ef88af
Compare
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
amd-hhashemi
requested review from
WoosukKwon,
mgoin,
tlrmchlsmth and
yewentao256
as code owners
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
gshtras
reviewed
Sep 19, 2025
|
This pull request has merge conflicts that must be resolved before it can be |
…ny gemm tests to be zero-centered, to avoid saturation and false passes. Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
amd-hhashemi
force-pushed
the
sknyGemmBias
branch
from
721aff6 to
faed43b
Compare
Signed-off-by: Hashem Hashemi <159079214+amd-hhashemi@users.noreply.github.com>
amd-hhashemi
changed the title
gshtras
approved these changes
Sep 22, 2025
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
auto-merge was automatically disabled
September 22, 2025 17:40
Head branch was pushed to by a user without write access
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
auto-merge was automatically disabled
September 23, 2025 07:36
Head branch was pushed to by a user without write access
gshtras
changed the title
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…oject#24988) Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com> Signed-off-by: Hashem Hashemi <159079214+amd-hhashemi@users.noreply.github.com>
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com> Signed-off-by: Hashem Hashemi <159079214+amd-hhashemi@users.noreply.github.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
gjc0824
pushed a commit
to gjc0824/vllm
that referenced
this pull request
Oct 10, 2025
…oject#24988) Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com> Signed-off-by: Hashem Hashemi <159079214+amd-hhashemi@users.noreply.github.com> Signed-off-by: gaojc <1055866782@qq.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…oject#24988) Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com> Signed-off-by: Hashem Hashemi <159079214+amd-hhashemi@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…oject#24988) Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com> Signed-off-by: Hashem Hashemi <159079214+amd-hhashemi@users.noreply.github.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…oject#24988) Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com> Signed-off-by: Hashem Hashemi <159079214+amd-hhashemi@users.noreply.github.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…oject#24988) Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com> Signed-off-by: Hashem Hashemi <159079214+amd-hhashemi@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.