Skip to content

Update PyTorch to 2.9.0+cu129 #24994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 52 commits into from
Oct 21, 2025
Merged

Update PyTorch to 2.9.0+cu129 #24994

merged 52 commits into from
Oct 21, 2025
+68 −67

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Sep 16, 2025 •
edited by github-actions bot
Loading

Purpose

Upgrade PyTorch to 2.9.0+cu129

Test Plan

CI

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results

@mergify mergify bot added ci/build rocm Related to AMD ROCm labels Sep 16, 2025
@BoyuanFeng
Copy link
Contributor

BoyuanFeng commented Sep 16, 2025

Thanks for the upgrade! #24281 requires PyTorch 2.9 and hopefully this PR will test it.

@huydhn
Update PyTorch to 2.9.0
e738cba 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Add a comment
497cffd 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Not setting --extra-index-url in test.in
89ba43a 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Use https://download.pytorch.org/whl/test
157aae3 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Merge branch 'main' into pytorch-2.9.0
ea1ef7a 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Put torchao back to the same state
0a81fb2 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Install the latest torchao nightly for quantization test
0325966 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Debug distributed failures
39b9cbf 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Wrong torchao package
0272040 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Attempt the fix in NVIDIA/nccl#1838
c2e0eaf 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn huydhn mentioned this pull request Sep 19, 2025
Merged
@huydhn
Copy link
Contributor Author

huydhn commented Sep 19, 2025 •
edited
Loading

TODO: Check the signals of tests from #24281 once it lands and the next 2.9 RC

@mergify
Copy link

mergify bot commented Sep 20, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @huydhn.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 20, 2025
@ProExpertProg
Copy link
Collaborator

ProExpertProg commented Sep 22, 2025

@huydhn when you get a chance can you set CompilationConfig.inductor_graph_partition to True by default in this PR to test CI with it?

@ProExpertProg ProExpertProg self-requested a review September 22, 2025 21:54
@huydhn
Merge branch 'main' into pytorch-2.9.0
c16db74 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Set inductor_graph_partition to True by default
d3436a8 
Signed-off-by: Huy Do <huydhn@gmail.com>
@mergify mergify bot removed the needs-rebase label Sep 23, 2025
huydhn
huydhn commented Sep 23, 2025
View reviewed changes
@ProExpertProg
Copy link
Collaborator

ProExpertProg commented Sep 23, 2025

@huydhn the pytorch compilation tests failure looks related, we need the old piecewise test using use_inductor_graph_partition=False to be set explicitly

@huydhn
Rerun with RC3
0e581a3 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Rerun with RC4
84c6cc3 
Signed-off-by: Huy Do <huydhn@gmail.com>
@mergify mergify bot added the documentation Improvements or additions to documentation label Sep 24, 2025
@mergify
Copy link

mergify bot commented Sep 26, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @huydhn.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Sep 26, 2025
@ProExpertProg ProExpertProg added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 18, 2025
@ProExpertProg
Copy link
Collaborator

ProExpertProg commented Oct 18, 2025

Merged, and I added ready, makes sense about the build branch

zou3519
zou3519 approved these changes Oct 19, 2025
View reviewed changes
Copy link
Collaborator

@zou3519 zou3519 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what to do about the gdrcopy thing but otherwise lgtm

@zou3519 zou3519 enabled auto-merge (squash) October 19, 2025 15:15
@huydhn
Merge branch 'main' into pytorch-2.9.0
1b8abc9 
Signed-off-by: Huy Do <huydhn@gmail.com>
auto-merge was automatically disabled October 20, 2025 17:34

Head branch was pushed to by a user without write access

@zou3519 zou3519 enabled auto-merge (squash) October 20, 2025 17:47
@jeejeelee jeejeelee mentioned this pull request Oct 21, 2025
Closed
1 task
@huydhn
Still need this tweak to avoid OOM
041e1c6 
Signed-off-by: Huy Do <huydhn@gmail.com>
auto-merge was automatically disabled October 21, 2025 08:56

Head branch was pushed to by a user without write access

@huydhn
Set --prerelease=allow to install apache-tvm-ffi
4fa09d7 
Signed-off-by: Huy Do <huydhn@gmail.com>
@tlrmchlsmth tlrmchlsmth linked an issue Oct 21, 2025 that may be closed by this pull request
[Feature]: Upgrade CUDA version to 12.9.1 in docker images #27208
Closed
1 task
@huydhn
Another --prerelease=allow
f2bb490 
Signed-off-by: Huy Do <huydhn@gmail.com>
@mergify
Copy link

mergify bot commented Oct 21, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @huydhn.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Oct 21, 2025
@huydhn
Merge branch 'main' into pytorch-2.9.0
91d5fab 
Signed-off-by: Huy Do <huydhn@gmail.com>
@mergify mergify bot removed the needs-rebase label Oct 21, 2025
@mergify mergify bot added the v1 label Oct 21, 2025
@huydhn
Urgh!
336edb2 
Signed-off-by: Huy Do <huydhn@gmail.com>
@aarnphm aarnphm merged commit becb7de into vllm-project:main Oct 21, 2025
87 checks passed
baonudesifeizhai pushed a commit to baonudesifeizhai/vllm that referenced this pull request Oct 21, 2025
@huydhn @ProExpertProg @baonudesifeizhai
Update PyTorch to 2.9.0+cu129 (vllm-project#24994)
8ead512 
Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com>
@huydhn huydhn mentioned this pull request Oct 21, 2025
Merged
sstamenk pushed a commit to sstamenk/vllm that referenced this pull request Oct 23, 2025
@huydhn @ProExpertProg @sstamenk
Update PyTorch to 2.9.0+cu129 (vllm-project#24994)
4becdc6 
Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com>
Signed-off-by: sstamenk <strahinja.stamenkovic@amd.com>
usberkeley pushed a commit to usberkeley/vllm that referenced this pull request Oct 23, 2025
@huydhn @ProExpertProg @usberkeley
Update PyTorch to 2.9.0+cu129 (vllm-project#24994)
793766c 
Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com>
albertoperdomo2 pushed a commit to albertoperdomo2/vllm that referenced this pull request Oct 23, 2025
@huydhn @ProExpertProg @albertoperdomo2
Update PyTorch to 2.9.0+cu129 (vllm-project#24994)
a3d1292 
Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
@huydhn @ProExpertProg @0xrushi
Update PyTorch to 2.9.0+cu129 (vllm-project#24994)
063cb5c 
Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
@huydhn @ProExpertProg @0xrushi
Update PyTorch to 2.9.0+cu129 (vllm-project#24994)
482a9dd 
Co-authored-by: Luka Govedič <ProExpertProg@users.noreply.github.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@zou3519 zou3519 zou3519 approved these changes

@aarnphm aarnphm aarnphm approved these changes

@ProExpertProg ProExpertProg Awaiting requested review from ProExpertProg

@bigPYJ1151 bigPYJ1151 Awaiting requested review from bigPYJ1151 bigPYJ1151 is a code owner

@jeejeelee jeejeelee Awaiting requested review from jeejeelee jeejeelee is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@LucasWilkinson LucasWilkinson Awaiting requested review from LucasWilkinson LucasWilkinson is a code owner

@mgoin mgoin Awaiting requested review from mgoin

@hmellor hmellor Awaiting requested review from hmellor hmellor is a code owner

Assignees

No one assigned

Labels

ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm v1

Projects

None yet

Milestone

v0.11.1

Development

Successfully merging this pull request may close these issues.

[Feature]: Upgrade CUDA version to 12.9.1 in docker images

8 participants

@huydhn @BoyuanFeng @ProExpertProg @mgoin @zou3519 @hmellor @aarnphm @tlrmchlsmth