-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[spec decode] Consolidate speculative decode method name for MTP #25232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spec decode] Consolidate speculative decode method name for MTP #25232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request consolidates various MTP speculative decoding method names into a unified "mtp" method. The implementation of this consolidation in the configuration and core logic appears correct. However, I've identified a few areas for improvement, primarily in the tests, which are still using deprecated method names, and a misleading warning message. My review includes suggestions to align the tests with the new consolidated method and to clarify the warning message for better user experience.
2de5a65 to
7e9f9da
Compare
601f399 to
b649014
Compare
b649014 to
b306c93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for consolidating the codes.
4090c55 to
d9325f6
Compare
Signed-off-by: zixi-qi <qizixi@meta.com>
Signed-off-by: zixi-qi <qizixi@meta.com>
Signed-off-by: zixi-qi <qizixi@meta.com>
Signed-off-by: zixi-qi <qizixi@meta.com>
Signed-off-by: zixi-qi <qizixi@meta.com>
Signed-off-by: zixi-qi <qizixi@meta.com>
d9325f6 to
94b8a63
Compare
…m-project#25232) Signed-off-by: zixi-qi <qizixi@meta.com>
…m-project#25232) Signed-off-by: zixi-qi <qizixi@meta.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…m-project#25232) Signed-off-by: zixi-qi <qizixi@meta.com>
Signed-off-by: zixi-qi <qizixi@meta.com>
…m-project#25232) Signed-off-by: zixi-qi <qizixi@meta.com>
…m-project#25232) Signed-off-by: zixi-qi <qizixi@meta.com>
…m-project#25232) Signed-off-by: zixi-qi <qizixi@meta.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
Stack on top of #25221
Currently there are multiple duplicated speculative decode method names for MTP: "deepseek_mtp", "ernie_mtp", "qwen3_next_mtp", "mimo_mtp". This PR consolidates them into one "mtp" method so that we do not need to keep appending this list when creating new models with MTP
Test Plan
Ran unit tests and e2e tests
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.