-
-
Notifications
You must be signed in to change notification settings - Fork 11.5k
[docs] Prompt Embedding feature support #25288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Prompt Embedding feature support #25288
Conversation
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to add documentation for Prompt Embedding support in the v1 engine. However, my review found a critical contradiction. Other files in the codebase, including a test file and another documentation file, indicate that this feature is not yet supported in v1. This suggests the documentation update may be based on a false premise and could mislead users. I've added a critical comment to highlight this discrepancy.
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
Signed-off-by: Andrew Sansom <andrew@protopia.ai> Signed-off-by: charlifu <charlifu@amd.com>
Signed-off-by: Andrew Sansom <andrew@protopia.ai> Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: Andrew Sansom <andrew@protopia.ai> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
Signed-off-by: Andrew Sansom <andrew@protopia.ai> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
#24278 officially enabled support for Prompt Embeddings in the v1 engine, and achieved feature parity with the implementation in the v0 engine. Since it's now available in both engines, I think it makes sense to add Prompt Embeds to the feature matrix in the docs so that it is clearly documented what features will and wont work with them.
Test Plan
N/A
Test Result
N/A
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.