Skip to content

Conversation

@qthequartermasterman
Copy link
Contributor

@qthequartermasterman qthequartermasterman commented Sep 19, 2025

Purpose

#24278 officially enabled support for Prompt Embeddings in the v1 engine, and achieved feature parity with the implementation in the v0 engine. Since it's now available in both engines, I think it makes sense to add Prompt Embeds to the feature matrix in the docs so that it is clearly documented what features will and wont work with them.

Test Plan

N/A

Test Result

N/A


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Andrew Sansom <andrew@protopia.ai>
@mergify mergify bot added the documentation Improvements or additions to documentation label Sep 19, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to add documentation for Prompt Embedding support in the v1 engine. However, my review found a critical contradiction. Other files in the codebase, including a test file and another documentation file, indicate that this feature is not yet supported in v1. This suggests the documentation update may be based on a false premise and could mislead users. I've added a critical comment to highlight this discrepancy.

Signed-off-by: Andrew Sansom <andrew@protopia.ai>
@vllm-bot vllm-bot merged commit b8a287a into vllm-project:main Sep 20, 2025
15 checks passed
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
Signed-off-by: charlifu <charlifu@amd.com>
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: Andrew Sansom <andrew@protopia.ai>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants