Skip to content

[V0 Deprecation] Remove V0 Sequence class & Sampler #25332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 21, 2025
Merged

[V0 Deprecation] Remove V0 Sequence class & Sampler #25332

merged 12 commits into from
Sep 21, 2025

Conversation

@WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Sep 21, 2025

No description provided.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 21, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a large-scale cleanup, removing the V0 Sequence and Sampler implementations and related code. The changes are extensive and touch many files, including removing entire modules. The review focuses on ensuring that the removal is clean and doesn't leave behind confusing artifacts like commented-out code or placeholder classes. I've identified a few areas where the cleanup could be improved for better maintainability and to prevent potential issues.

@WoosukKwon
rm
b89ce92 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@mergify mergify bot added multi-modality Related to multi-modality (#4194) v1 labels Sep 21, 2025
@WoosukKwon WoosukKwon added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 21, 2025
WoosukKwon and others added 5 commits September 20, 2025 21:55
@WoosukKwon
fix phi4flash
09a2a62 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@WoosukKwon
rm input_registry
1e13f60 
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
@WoosukKwon
fix executor_base
dc28253 
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
@WoosukKwon
precommit
38d942f 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@WoosukKwon
detokenizer
0cdc384 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
@mergify mergify bot added qwen Related to Qwen models tool-calling labels Sep 21, 2025
@WoosukKwon WoosukKwon merged commit 26e673f into main Sep 21, 2025
52 of 53 checks passed
@WoosukKwon WoosukKwon deleted the woosuk/rm-v0-seq branch September 21, 2025 15:52
@Potabk Potabk mentioned this pull request Sep 22, 2025
Closed
kingsmad pushed a commit to kingsmad/vllm that referenced this pull request Sep 22, 2025
@WoosukKwon @kingsmad
[V0 Deprecation] Remove V0 Sequence class & Sampler (vllm-project#25332)
b2e5dc1 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
@adobrzyn adobrzyn mentioned this pull request Sep 22, 2025
Merged
@Potabk Potabk mentioned this pull request Sep 22, 2025
Merged
kzawora-intel added a commit to vllm-project/vllm-gaudi that referenced this pull request Sep 22, 2025
@adobrzyn @kzawora-intel
[BUGFIX] Fix after PR25332 & 25321 & 25366 (#215)
d930dea 
Culprit commit : vllm-project/vllm#25332 and
vllm-project/vllm#25321 and
vllm-project/vllm#25366

---------

Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
Signed-off-by: Konrad Zawora <kzawora@habana.ai>
Co-authored-by: Konrad Zawora <kzawora@habana.ai>
wangxiyuan pushed a commit to vllm-project/vllm-ascend that referenced this pull request Sep 22, 2025
@Potabk
[CI] Update vllm version to 20250922(5aeb925) (#3091)
02f89d1 
### What this PR does / why we need it?
This pr bump vllm commit hash to
vllm-project/vllm@5aeb925
fix issues:  
1. vllm-project/vllm#25345 has remove v0
metadata
2. vllm-project/vllm#25332
3. vllm-project/vllm#25334
4. vllm-project/vllm#23558, note that this vllm
commit update the model register logic, which will check all the model
registered have the `vllm.model_executor.models` path , which breaks our
custom registration of the deepseek_v3 model (it doesn't exist in the
vllm model path). so I move deepseek_v3 model registy to deepseek_v2 to
solve temporary

### How was this patch tested?

- vLLM version: v0.10.2
- vLLM main:
vllm-project/vllm@9607d5e

---------

Signed-off-by: wangli <wangli858794774@gmail.com>
slokesha pushed a commit to slokesha/vllm-gaudi that referenced this pull request Sep 24, 2025
@adobrzyn @kzawora-intel @slokesha
[BUGFIX] Fix after PR25332 & 25321 & 25366 (vllm-project#215)
86caf89 
Culprit commit : vllm-project/vllm#25332 and
vllm-project/vllm#25321 and
vllm-project/vllm#25366

---------

Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
Signed-off-by: Konrad Zawora <kzawora@habana.ai>
Co-authored-by: Konrad Zawora <kzawora@habana.ai>
Signed-off-by: slokesha <slokeshappa@habana.ai>
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
@WoosukKwon @FeiDaLI
[V0 Deprecation] Remove V0 Sequence class & Sampler (vllm-project#25332)
33c683a 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
charlifu pushed a commit to ROCm/vllm that referenced this pull request Sep 25, 2025
@WoosukKwon @charlifu
[V0 Deprecation] Remove V0 Sequence class & Sampler (vllm-project#25332)
4bd4671 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
Signed-off-by: charlifu <charlifu@amd.com>
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
@WoosukKwon @yewentao256
[V0 Deprecation] Remove V0 Sequence class & Sampler (#25332)
81e17a1 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@WoosukKwon @xuebwang-amd
[V0 Deprecation] Remove V0 Sequence class & Sampler (vllm-project#25332)
5e206ae 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
@WoosukKwon @choprahetarth
[V0 Deprecation] Remove V0 Sequence class & Sampler (vllm-project#25332)
5b23776 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
@WoosukKwon @lywa1998
[V0 Deprecation] Remove V0 Sequence class & Sampler (vllm-project#25332)
ad2af38 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
Angazenn pushed a commit to Angazenn/vllm-ascend that referenced this pull request Oct 21, 2025
@Potabk @Angazenn
[CI] Update vllm version to 20250922(5aeb925) (vllm-project#3091)
660cd5c 
### What this PR does / why we need it?
This pr bump vllm commit hash to
vllm-project/vllm@5aeb925
fix issues:  
1. vllm-project/vllm#25345 has remove v0
metadata
2. vllm-project/vllm#25332
3. vllm-project/vllm#25334
4. vllm-project/vllm#23558, note that this vllm
commit update the model register logic, which will check all the model
registered have the `vllm.model_executor.models` path , which breaks our
custom registration of the deepseek_v3 model (it doesn't exist in the
vllm model path). so I move deepseek_v3 model registy to deepseek_v2 to
solve temporary

### How was this patch tested?

- vLLM version: v0.10.2
- vLLM main:
vllm-project/vllm@9607d5e

---------

Signed-off-by: wangli <wangli858794774@gmail.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@WoosukKwon @xuebwang-amd
[V0 Deprecation] Remove V0 Sequence class & Sampler (vllm-project#25332)
55baced 
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Signed-off-by: Woosuk Kwon <woosuk@thinkingmachines.ai>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123 zhuohan123 is a code owner

@youkaichao youkaichao Awaiting requested review from youkaichao youkaichao is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@NickLucche NickLucche Awaiting requested review from NickLucche

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@22quinn 22quinn Awaiting requested review from 22quinn 22quinn is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

multi-modality Related to multi-modality (#4194) qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding tool-calling v1

Projects

Tool Calling
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WoosukKwon