[V1] Remove V0 code paths for Hybrid models #25400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
tdoublep
requested review from
DarkLight1337,
WoosukKwon,
alexm-redhat,
comaniac,
njhill,
robertgshaw2-redhat,
sighingnow and
ywang96
as code owners
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
WoosukKwon
approved these changes
Sep 22, 2025
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
charlifu
pushed a commit
to ROCm/vllm
that referenced
this pull request
Sep 25, 2025
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: charlifu <charlifu@amd.com>
5 tasks
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
gjc0824
pushed a commit
to gjc0824/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: gaojc <1055866782@qq.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Thomas Parnell <tpa@zurich.ibm.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove V0 code path from the following models:
Please now that the model
phi4flashhas not been ported to V1 yet (#23996) and is non-trival to do so (requires porting differential attention backend). This PR removes the modeling code for that model. It can be re-added once the porting is done. The code will be useless until then anyway since V0 has been removed.Test Plan
Hybrid model test should verify nearly all of the above. I have run it locally. Let's see what happens in CI.
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.