-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[V0 deprecation] Remove platform v1 controling interface #25410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the supports_v1 and default_v1 methods from the platform interfaces, aiming to clean up V0 deprecation-related code. The changes are consistent across the codebase, removing the method definitions and their usages. However, this change removes a safeguard that prevented V1 from being enabled on new or untested platforms. I've raised a critical concern about the potential for enabling V1 on incompatible platforms, which could lead to runtime issues. It's important to clarify whether V0 is fully removed, as this would dictate whether more V0-related fallback logic should be cleaned up, or if a new safeguard is needed.
…t#25410) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…t#25410) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…t#25410) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: charlifu <charlifu@amd.com>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: yewentao256 <zhyanwentao@126.com>
…t#25410) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: gaojc <1055866782@qq.com>
…t#25410) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…t#25410) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…t#25410) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
…t#25410) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
supports_v1anddefault_v1to control v0 fallback at platform levelAlso cc @Yikun @xuechendi in case these interfaces are still used by plugins.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.