[ROCm][Build][Bugfix] Fix ROCm base docker whls installation order #25415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the ROCm base Dockerfile to improve the build process. Key changes include installing all wheel files in a single command to prevent dependency conflicts, and separating the FlashAttention build into its own stage to enable parallel builds. These are positive changes that enhance the robustness and efficiency of the Docker image creation. I have identified one high-severity issue related to the filtering of GPU architectures for the FlashAttention build, which could result in an incorrect build configuration. A suggestion to fix this is provided in the detailed comments.
SageMoore
approved these changes
Sep 23, 2025
ProExpertProg
approved these changes
Sep 24, 2025
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
…25415) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…llm-project#25415) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…llm-project#25415) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…llm-project#25415) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…llm-project#25415) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…llm-project#25415) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all whls install at the same command to fix the missing dependency issue when triton_kernels would pull CUDA dependencies from pypi
Split FA into its own build step to run in parallel