-
-
Couldn't load subscription status.
- Fork 10.9k
Add backward compatibility for GuidedDecodingParams
#25422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds backward compatibility for GuidedDecodingParams by reintroducing it as a deprecated alias for StructuredOutputsParams. The changes are logically sound for ensuring compatibility. However, the implementation introduces duplicated code for issuing deprecation warnings, which can impact maintainability and user experience. My review focuses on removing this redundancy.
|
Fo we need this for 0.11? im also good with breaking change |
|
We've been made aware that having the breaking change this sudden will causee a lot of breakages for RL use cases. As backwards compatibility goes, this is pretty unobtrusive to vLLM and very loud with warnings to encourage users to switch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems important and aligned with our deprecation policy: https://docs.vllm.ai/en/latest/contributing/deprecation_policy.html#deprecation-pipeline
It's actually proposing to skip the "Deprected + off by default" step, but I'm OK with that. I think that part is more important for HTTP API breakages, which are harder to inform the client about.
|
@minosfuture has imported this pull request. If you are a Meta employee, you can view this in D83067559. |
…5422) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
…5422) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: gaojc <1055866782@qq.com>
…5422) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…5422) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…5422) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…5422) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Reinstates backward compatiblility for the following APIs removed by #22772:
GuidedDecodingParamswhich wrapsStructuredOutputsParams(this was just a rename)guided_decodingback toSamplingParams/SamplingParams.from_optionaland forward the value tostructured_outputs_params