[Benchmark] Fix regression in structured output benchmark #25500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a mistake introduced by vllm-project#22772. Structured output requests were not actually working because the format spec was not placed in the proper new location in the request body. Signed-off-by: Russell Bryant <rbryant@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a regression in the structured output benchmark by updating how the request body is constructed for structured output requests. The schema is now properly nested under the structured_outputs key, aligning with the API. While this change is correct, I noticed that the code for stopping the profiler (around line 668) still uses the old, incorrect format for the extra_body. It would be good to fix this as well to ensure profiling works correctly.
github-actions
bot
added
the
ready
yewentao256
pushed a commit
that referenced
this pull request
Oct 3, 2025
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…ct#25500) Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth
pushed a commit
to Tandemn-Labs/vllm
that referenced
this pull request
Oct 11, 2025
…ct#25500) Signed-off-by: Russell Bryant <rbryant@redhat.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…ct#25500) Signed-off-by: Russell Bryant <rbryant@redhat.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…ct#25500) Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a mistake introduced by #22772. Structured output requests
were not actually working because the format spec was not placed in
the proper new location in the request body.
Signed-off-by: Russell Bryant rbryant@redhat.com