-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[Bugfix] Lower gpt-oss max cudagraph size to 992 to be compatible with FA3 #25508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly addresses a crash on Hopper GPUs for the gpt-oss model by lowering the maximum CUDA graph capture size to 992, which is the compatibility limit for FlashAttention v3. The change is well-targeted and effective. I have one suggestion to improve the code's maintainability by replacing the hardcoded value 992 with a named constant.
…h FA3 (vllm-project#25508) Signed-off-by: mgoin <mgoin64@gmail.com>
…h FA3 (#25508) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
…h FA3 (vllm-project#25508) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: gaojc <1055866782@qq.com>
…h FA3 (vllm-project#25508) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…h FA3 (vllm-project#25508) Signed-off-by: mgoin <mgoin64@gmail.com>
…h FA3 (vllm-project#25508) Signed-off-by: mgoin <mgoin64@gmail.com>
…h FA3 (vllm-project#25508) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
Due to compiling full cudagraphs by default now in #25444, gpt-oss crashes on Hopper.
Test Plan
Test Result
vllm serve openai/gpt-oss-20bcrashes on main but succeeds with this PREssential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.