-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[Compile] Fix AMD Compile Error #25518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
9f8ae87 to
48b3f69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes a compilation error on AMD MI300 devices by adding compatibility layers for different ROCm versions, specifically for FP8 data types. The changes correctly address the issue by defining missing FP8 type aliases for older ROCm versions. However, this compatibility logic is now fragmented across multiple files. I've added comments suggesting to centralize this logic into a common header to improve code maintainability and consistency.
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: gaojc <1055866782@qq.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Purpose
Fix AMD Compile Error in MI300
Originally
Now