Skip to content

[Bugfix] Add triton.language.tensor placeholder #25649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2025
Merged

[Bugfix] Add triton.language.tensor placeholder #25649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c99efa3
Add triton.language.tensor placeholder
adobrzyn Sep 25, 2025
2c10793
Test fix
adobrzyn Sep 25, 2025
830de13
Merge branch 'main' into triton_triton_language_add_tensor
adobrzyn Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/test_triton_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ def test_triton_placeholder_language():
assert lang.constexpr is None
assert lang.dtype is None
assert lang.int64 is None
assert lang.int32 is None
assert lang.tensor is None


def test_triton_placeholder_language_from_parent():
Expand Down
1 change: 1 addition & 0 deletions vllm/triton_utils/importing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,4 @@ def __init__(self):
self.dtype = None
self.int64 = None
self.int32 = None
self.tensor = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change correctly adds the tensor attribute. To prevent future regressions, please also update the corresponding unit test in tests/test_triton_utils.py.

The test_triton_placeholder_language function is incomplete and should be updated to check for all attributes of TritonLanguagePlaceholder, including the newly added tensor.

Here is a suggested update for the test:

def test_triton_placeholder_language():
    lang = TritonLanguagePlaceholder()
    assert isinstance(lang, types.ModuleType)
    assert lang.__name__ == "triton.language"
    assert lang.constexpr is None
    assert lang.dtype is None
    assert lang.int64 is None
    assert lang.int32 is None
    assert lang.tensor is None

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added both int32 and tensor attribute