Revert "[Bug] Dynamo Unsupported due to BasevLLMParameter.torch_function calling disabled super()"
#25681
Conversation
…tion` ca…" This reverts commit 4492e3a. Signed-off-by: yewentao256 <zhyanwentao@126.com>
yewentao256
force-pushed
the
revert-25613-wentao-fix-torch-function-super-issue
branch
from
be236f9 to
416c7d5
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that introduced a workaround for TorchDynamo on PyTorch versions older than 2.8.0. The reverted code in BasevLLMParameter.__torch_function__ returned NotImplemented on these older PyTorch versions. While this fixed a TorchDynamo issue, it appears to have introduced a critical regression related to LoRA adapters, causing infinite recursion. This revert correctly removes the version-specific logic, restoring the previous behavior of always delegating to super().__torch_function__. This resolves the LoRA regression. While this reintroduces the original TorchDynamo issue for users on older PyTorch versions, this seems to be an intentional trade-off. The change is simple, clean, and effectively addresses the immediate regression. The code is correct and I have no further suggestions.
This fixes the DCO CI runs |
vllm-bot
deleted the
revert-25613-wentao-fix-torch-function-super-issue
branch
…tion` calling disabled super()" (#25681) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
…tion` calling disabled super()" (vllm-project#25681) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…tion` calling disabled super()" (vllm-project#25681) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>
…tion` calling disabled super()" (vllm-project#25681) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com>
…tion` calling disabled super()" (vllm-project#25681) Signed-off-by: yewentao256 <zhyanwentao@126.com> Co-authored-by: Wentao Ye <44945378+yewentao256@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Reverts #25613