Skip to content

Conversation

@ywang96
Copy link
Member

@ywang96 ywang96 commented Sep 28, 2025

Purpose

#24982 caused a regression since the Qwen3-VL needs to access the text config of Qwen3-MoE via get_text_config()

Test Plan

Test Result

Tested locally to make sure both Qwen3-VL and Qwen3-MoE can load properly.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Roger Wang <hey@rogerw.io>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a regression for Qwen3-VL by ensuring the text model configuration is used. The change replaces vllm_config.model_config.hf_config with vllm_config.model_config.hf_config.get_text_config(). While this fixes the issue for the multimodal Qwen3-VL model, it will likely cause a regression for the standalone Qwen3-MoE model, as the Hugging Face configuration for a non-multimodal model typically does not have a get_text_config() method, which would lead to an AttributeError. I've suggested a more robust fix in the comments, which is to use vllm_config.model_config.hf_text_config. This attribute is correctly populated by vLLM's ModelConfig to handle both multimodal and text-only models. This change should be applied to all instances, including the one in Qwen3MoeModel.__init__ which is not part of this PR's diff but contains the same pattern.

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 28, 2025
Signed-off-by: Roger Wang <hey@rogerw.io>
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) September 28, 2025 03:11
@tlrmchlsmth tlrmchlsmth merged commit 6144754 into vllm-project:main Sep 28, 2025
50 checks passed
simon-mo pushed a commit that referenced this pull request Sep 28, 2025
Signed-off-by: Roger Wang <hey@rogerw.io>
Signed-off-by: simon-mo <simon.mo@hey.com>
baonudesifeizhai pushed a commit to baonudesifeizhai/vllm that referenced this pull request Sep 28, 2025
…t#25814)

Signed-off-by: Roger Wang <hey@rogerw.io>
Signed-off-by: baonudesifeizhai <baonudesifeizhai@gmail.com>
pdasigi pushed a commit to pdasigi/vllm that referenced this pull request Oct 2, 2025
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
Signed-off-by: Roger Wang <hey@rogerw.io>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
…t#25814)

Signed-off-by: Roger Wang <hey@rogerw.io>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
choprahetarth pushed a commit to Tandemn-Labs/vllm that referenced this pull request Oct 11, 2025
…t#25814)

Signed-off-by: Roger Wang <hey@rogerw.io>
Signed-off-by: simon-mo <simon.mo@hey.com>
shyeh25 pushed a commit to shyeh25/vllm that referenced this pull request Oct 14, 2025
Signed-off-by: Roger Wang <hey@rogerw.io>
Signed-off-by: simon-mo <simon.mo@hey.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
…t#25814)

Signed-off-by: Roger Wang <hey@rogerw.io>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants