Skip to content

[Model] Remove MotifForCausalLM #25866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2025
Merged

[Model] Remove MotifForCausalLM #25866

merged 2 commits into from
Sep 29, 2025
+1 −355

Conversation

@jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Sep 29, 2025 •
edited by github-actions bot
Loading

Purpose

  • Similar to Phi4FlashForCausalLM, vLLM no longer supports MotifForCausalLM, so remove the related code
  • Clean up Phi4FlashForCausalLM related code

error info

  Value error, Model architecture MotifForCausalLM was supported in vLLM until v0.10.2, and is not supported anymore. Please use an older version of vLLM if you want to use this model architecture. [type=value_error, input_value=ArgsKwargs((), {'model': ...rocessor_plugin': None}), input_type=ArgsKwargs]

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@jeejeelee
Done
3c053e8 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee
fix version
abf8649 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@mergify mergify bot added documentation Improvements or additions to documentation new-model Requests to new models labels Sep 29, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Sep 29, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes the MotifForCausalLM model and cleans up related code. The changes are consistent across documentation, model registry, and tests, achieving the stated purpose. I have one suggestion regarding a potential follow-up cleanup to remove dead code that might have resulted from this model's removal.

vllm/model_executor/models/motif.py
if hidden_act != "poly_norm":
raise NotImplementedError(f"Unsupported activation: {hidden_act}. "
"Only poly_norm is supported for now.")
self.act_fn = PolyNorm()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

With the removal of MotifForCausalLM, the PolyNorm activation function, which was used by this model, may now be unused. If no other models utilize PolyNorm, consider removing it and its associated custom op poly_norm from vllm/model_executor/layers/layernorm.py to improve code maintainability by eliminating dead code.

Copy link
Collaborator Author

@jeejeelee jeejeelee Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the related code will be deleted in a later PR

@jeejeelee jeejeelee requested a review from Isotr0py September 29, 2025 08:55
@DarkLight1337
Copy link
Member

Are the model authors aware of this?

@jeejeelee
Copy link
Collaborator Author

jeejeelee commented Sep 29, 2025 •
edited
Loading

Are the model authors aware of this?

Given that we've removed support for Differential Flash Attention, these cleanups are safe and necessary CC @ca1207

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 29, 2025
@DarkLight1337 DarkLight1337 merged commit e61eb5e into vllm-project:main Sep 29, 2025
53 of 54 checks passed
@jeejeelee jeejeelee deleted the remove-motify branch September 29, 2025 16:42
pdasigi pushed a commit to pdasigi/vllm that referenced this pull request Oct 2, 2025
@jeejeelee @pdasigi
[Model] Remove MotifForCausalLM (vllm-project#25866)
9f91bc2 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
yewentao256 pushed a commit that referenced this pull request Oct 3, 2025
@jeejeelee @yewentao256
[Model] Remove MotifForCausalLM (#25866)
2405817 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
tomeras91 pushed a commit to tomeras91/vllm that referenced this pull request Oct 6, 2025
@jeejeelee @tomeras91
[Model] Remove MotifForCausalLM (vllm-project#25866)
671b93c 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@jeejeelee @xuebwang-amd
[Model] Remove MotifForCausalLM (vllm-project#25866)
ebb1790 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
@jeejeelee @lywa1998
[Model] Remove MotifForCausalLM (vllm-project#25866)
10d162d 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@WyldeCat WyldeCat mentioned this pull request Oct 23, 2025
Open
5 tasks
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
@jeejeelee @alhridoy
[Model] Remove MotifForCausalLM (vllm-project#25866)
eddd799 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@jeejeelee @xuebwang-amd
[Model] Remove MotifForCausalLM (vllm-project#25866)
6503f6d 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation new-model Requests to new models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeejeelee @DarkLight1337 @Isotr0py