[Benchmark] Finish documented v0.11.0 deprecation of --endpoint-type #26007
Conversation
Signed-off-by: Nathan Scott <nathans@redhat.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully removes the deprecated --endpoint-type command-line argument from the vllm bench serve utility, as planned for v0.11.0. The changes are straightforward and correct, deleting the DeprecatedEndpointTypeAction class and the argument's definition in argparse. The functionality is now consolidated under the --backend argument. The changes are well-contained and achieve the stated goal. The code looks good.
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
github-actions
bot
added
the
ready
…llm-project#26007) Signed-off-by: Nathan Scott <nathans@redhat.com>
…26007) Signed-off-by: Nathan Scott <nathans@redhat.com> Signed-off-by: yewentao256 <zhyanwentao@126.com>
…llm-project#26007) Signed-off-by: Nathan Scott <nathans@redhat.com> Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
…llm-project#26007) Signed-off-by: Nathan Scott <nathans@redhat.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…llm-project#26007) Signed-off-by: Nathan Scott <nathans@redhat.com>
…llm-project#26007) Signed-off-by: Nathan Scott <nathans@redhat.com>
…llm-project#26007) Signed-off-by: Nathan Scott <nathans@redhat.com>
…llm-project#26007) Signed-off-by: Nathan Scott <nathans@redhat.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…llm-project#26007) Signed-off-by: Nathan Scott <nathans@redhat.com>
2 participants
Purpose
Remove the vllm bench --endpoint-type option, as described in the deprecation message for some time.
Test Plan
Ran multiple benchmarks as normal with code removed.
Test Result
No issues observed.