Skip to content

[Perf][Easy] Early stop in request_block_hasher #26112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2025
Merged

[Perf][Easy] Early stop in request_block_hasher #26112

merged 1 commit into from
Oct 5, 2025

Conversation

@Jialin
Copy link
Collaborator

@Jialin Jialin commented Oct 2, 2025 •
edited by github-actions bot
Loading

Purpose

Most request_block_hasher will NOT introduce new blocks, early stop in request_block_hasher to avoid unnecessary computations.

Test Plan & Test Result

Before
Screenshot 2025-10-02 at 9 46 34 AM

After
Screenshot 2025-10-02 at 9 48 04 AM

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added the v1 label Oct 2, 2025
@Jialin Jialin marked this pull request as ready for review October 2, 2025 17:24
@Jialin Jialin mentioned this pull request Oct 2, 2025
Open
1 task
heheda12345
heheda12345 approved these changes Oct 2, 2025
View reviewed changes
Copy link
Collaborator

@heheda12345 heheda12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@heheda12345 heheda12345 enabled auto-merge (squash) October 2, 2025 17:32
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 2, 2025
@Jialin
Early stop in requet_block_hasher
1a3f2a4 
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
auto-merge was automatically disabled October 3, 2025 21:05

Head branch was pushed to by a user without write access

@DarkLight1337 DarkLight1337 merged commit 201c971 into vllm-project:main Oct 5, 2025
45 checks passed
tomeras91 pushed a commit to tomeras91/vllm that referenced this pull request Oct 6, 2025
@Jialin @tomeras91
[Perf][Easy] Early stop in request_block_hasher (vllm-project#26112)
668ba11 
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
karan pushed a commit to karan/vllm that referenced this pull request Oct 6, 2025
@Jialin @karan
[Perf][Easy] Early stop in request_block_hasher (vllm-project#26112)
807ff40 
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>
southfreebird pushed a commit to southfreebird/vllm that referenced this pull request Oct 7, 2025
@Jialin @southfreebird
[Perf][Easy] Early stop in request_block_hasher (vllm-project#26112)
0896a41 
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@Jialin @xuebwang-amd
[Perf][Easy] Early stop in request_block_hasher (vllm-project#26112)
c9ed681 
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
@Jialin @lywa1998
[Perf][Easy] Early stop in request_block_hasher (vllm-project#26112)
3d0169f 
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
@Jialin @alhridoy
[Perf][Easy] Early stop in request_block_hasher (vllm-project#26112)
ce4e43f 
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@Jialin @xuebwang-amd
[Perf][Easy] Early stop in request_block_hasher (vllm-project#26112)
dd6a0ad 
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
@Jialin @rtourgeman
[Perf][Easy] Early stop in request_block_hasher (vllm-project#26112)
aa3a020 
Signed-off-by: Jialin Ouyang <Jialin.Ouyang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heheda12345 heheda12345 heheda12345 approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

@ApostaC ApostaC Awaiting requested review from ApostaC ApostaC is a code owner

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jialin @heheda12345 @DarkLight1337