Skip to content

Conversation

@maxdebayser
Copy link
Contributor

Add documentation on recommended CLI args for tool calling with Granite 4.0 models.

Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
@mergify mergify bot added documentation Improvements or additions to documentation tool-calling labels Oct 3, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for using ibm-granite/granite-4.0-h-small with tool calling. The change specifies that the hermes tool call parser should be used for this model. The documentation change is clear, follows the existing structure, and appears to be correct. The change looks good to me.

@bbrowning
Copy link
Contributor

As someone who had to ask around to find this, thank you for documenting it 😄

@DarkLight1337 DarkLight1337 mentioned this pull request Oct 4, 2025
1 task
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
Copy link
Member

@tdoublep tdoublep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this

@tdoublep tdoublep enabled auto-merge (squash) October 5, 2025 07:34
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 5, 2025
@tdoublep tdoublep merged commit e0986ea into vllm-project:main Oct 5, 2025
8 checks passed
tomeras91 pushed a commit to tomeras91/vllm that referenced this pull request Oct 6, 2025
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
karan pushed a commit to karan/vllm that referenced this pull request Oct 6, 2025
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>
southfreebird pushed a commit to southfreebird/vllm that referenced this pull request Oct 7, 2025
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Signed-off-by: Max de Bayser <mbayser@br.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed tool-calling

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants