Skip to content

Conversation

@elieserr
Copy link
Contributor

@elieserr elieserr commented Oct 3, 2025

Update api versions used to test

Purpose

Minor fix on documentation to reflect proper endpoints for testing production-stack.md

Test Plan

Test Result

Old

curl -o- http://localhost:30080/models
{"detail":"Not Found"}

curl -X POST http://localhost:30080/completions \
  -H "Content-Type: application/json" \
  -d '{
    "model": "facebook/opt-125m",
    "prompt": "Once upon a time,",
    "max_tokens": 10
  }'
{"detail":"Not Found"}

New

curl -o- http://localhost:30080/v1/models
{"object":"list","data":[{"id":"facebook/opt-125m","object":"model","created":1759504980,"owned_by":"vllm","root":null,"parent":null}]}

curl -X POST http://localhost:30080/v1/completions   -H "Content-Type: application/json"   -d '{
    "model": "facebook/opt-125m",
    "prompt": "Once upon a time,",
    "max_tokens": 10
  }' | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   516  100   421  100    95    697    157 --:--:-- --:--:-- --:--:--   855
{
  "id": "cmpl-dbc8b3fdfaf34aa5990e6e00737c22ba",
  "object": "text_completion",
  "created": 1759505157,
  "model": "facebook/opt-125m",
  "choices": [
    {
      "index": 0,
      "text": " an American joke was jumbled into something equally silly",
      "logprobs": null,
      "finish_reason": "length",
      "stop_reason": null,
      "prompt_logprobs": null
    }
  ],
  "usage": {
    "prompt_tokens": 6,
    "total_tokens": 16,
    "completion_tokens": 10,
    "prompt_tokens_details": null
  },
  "kv_transfer_params": null
}


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

update api versions used  to test

Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com>
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Oct 3, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the production-stack.md documentation file to reflect the correct API endpoints. The changes from /models to /v1/models and /completions to /v1/completions are accurate and align with the server's routing implementation. This is a helpful correction to the documentation.

@22quinn 22quinn enabled auto-merge (squash) October 5, 2025 21:31
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 5, 2025
@22quinn 22quinn merged commit f509a20 into vllm-project:main Oct 5, 2025
14 of 15 checks passed
karan pushed a commit to karan/vllm that referenced this pull request Oct 6, 2025
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com>
Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>
southfreebird pushed a commit to southfreebird/vllm that referenced this pull request Oct 7, 2025
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants