-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[DOC] Update production-stack.md #26177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
update api versions used to test Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the production-stack.md documentation file to reflect the correct API endpoints. The changes from /models to /v1/models and /completions to /v1/completions are accurate and align with the server's routing implementation. This is a helpful correction to the documentation.
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com> Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com>
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com>
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com>
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Update api versions used to test
Purpose
Minor fix on documentation to reflect proper endpoints for testing production-stack.md
Test Plan
Test Result
Old
New
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.