Revert "Add batch invariant kernel override for FlashInfer backend [2/n]" #26220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkLight1337
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that added a batch invariant kernel override for the FlashInfer backend, which reportedly caused test failures. The revert appears to be clean and complete, correctly removing the feature and its associated logic from the FlashInfer backend implementation and the batch invariance layer. The corresponding test cases have also been reverted to their previous state. I have reviewed the changes and found no issues with the revert itself.
|
Let's confirm that the test in question now passes before merging |
simon-mo
approved these changes
Oct 4, 2025
tomeras91
pushed a commit
to tomeras91/vllm
that referenced
this pull request
Oct 6, 2025
…/n]" (vllm-project#26220) Signed-off-by: Tomer Asida <57313761+tomeras91@users.noreply.github.com>
karan
pushed a commit
to karan/vllm
that referenced
this pull request
Oct 6, 2025
…/n]" (vllm-project#26220) Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>
southfreebird
pushed a commit
to southfreebird/vllm
that referenced
this pull request
Oct 7, 2025
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…/n]" (vllm-project#26220) Signed-off-by: xuebwang-amd <xuebwang@amd.com>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…/n]" (vllm-project#26220) Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #25769 because it failed PyTorch Fullgraph Smoke Test