Fix per file ruff ignores related to simplification #26259
Conversation
Forward fixes some of the issues skipped by vllm-project#26247 Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
22quinn,
DarkLight1337,
LucasWilkinson,
NickLucche,
WoosukKwon,
aarnphm,
chaunceyjiang,
gshtras,
houseroad,
mgoin,
njhill,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
ywang96
as code owners
mergify
bot
added
frontend
multi-modality
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request applies a series of code simplifications suggested by ruff, primarily converting if/else statements to ternary expressions and other similar refactorings across numerous files. These changes enhance code conciseness and readability. A notable change is the correction of an environment variable name in vllm/executor/ray_distributed_executor.py, which is a good bug fix. All corresponding ruff ignores in pyproject.toml have been correctly removed. The changes are well-executed and I found no issues of high or critical severity.
github-actions
bot
added
the
ready
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Karan Goel <3261985+karan@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
2 participants
Forward fixes some of the issues skipped by #26247