Skip to content

Conversation

@fxmarty-amd
Copy link
Contributor

@fxmarty-amd fxmarty-amd commented Oct 7, 2025

As per title, as reported in #21166 (comment)

test_mxfp4_moe.py was renamed, but not in .buildkite/test-pipeline.yaml.

Not sure why the CI was green on the above PR.

Signed-off-by: Felix Marty <Felix.Marty@amd.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the test file name from test_mxfp4_moe.py to test_ocp_mx_moe.py in the .buildkite/test-pipeline.yaml CI configuration and in a docstring within tests/quantization/test_quark.py. The changes are correct and resolve the issue of the CI configuration being out of sync with the renamed test file. The PR looks good to merge.

@vllm-bot vllm-bot merged commit a38c1bf into vllm-project:main Oct 7, 2025
7 of 8 checks passed
patrickvonplaten pushed a commit to patrickvonplaten/vllm that referenced this pull request Oct 7, 2025
…#26364)

Signed-off-by: Felix Marty <Felix.Marty@amd.com>
Signed-off-by: Patrick von Platen <patrick.v.platen@gmail.com>
patrickvonplaten pushed a commit to patrickvonplaten/vllm that referenced this pull request Oct 7, 2025
…#26364)

Signed-off-by: Felix Marty <Felix.Marty@amd.com>
Signed-off-by: Patrick von Platen <patrick.v.platen@gmail.com>
patrickvonplaten pushed a commit to patrickvonplaten/vllm that referenced this pull request Oct 7, 2025
…#26364)

Signed-off-by: Felix Marty <Felix.Marty@amd.com>
Signed-off-by: Patrick von Platen <patrick.v.platen@gmail.com>
mrasquinha-g pushed a commit to mrasquinha-g/vllm that referenced this pull request Oct 9, 2025
…#26364)

Signed-off-by: Felix Marty <Felix.Marty@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
…#26364)

Signed-off-by: Felix Marty <Felix.Marty@amd.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Dhruvilbhatt pushed a commit to Dhruvilbhatt/vllm that referenced this pull request Oct 14, 2025
…#26364)

Signed-off-by: Felix Marty <Felix.Marty@amd.com>
Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
…#26364)

Signed-off-by: Felix Marty <Felix.Marty@amd.com>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
…#26364)

Signed-off-by: Felix Marty <Felix.Marty@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
…#26364)

Signed-off-by: Felix Marty <Felix.Marty@amd.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants