Skip to content

[CI/Build] Fix model nightly tests #26466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2025
Merged

[CI/Build] Fix model nightly tests #26466

merged 2 commits into from
Oct 9, 2025
+9 −7

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Oct 9, 2025 •
edited by github-actions bot
Loading

Purpose

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@DarkLight1337 DarkLight1337 requested a review from ywang96 as a code owner October 9, 2025 04:35
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 9, 2025
@mergify mergify bot added multi-modality Related to multi-modality (#4194) performance Performance-related issues gpt-oss Related to GPT-OSS models v1 labels Oct 9, 2025
@DarkLight1337
[CI/Build] Fix model nightly tests
217f039 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 removed performance Performance-related issues v1 gpt-oss Related to GPT-OSS models labels Oct 9, 2025
@DarkLight1337 DarkLight1337 added actionable There is clear action for a vLLM developer to take ci/build and removed multi-modality Related to multi-modality (#4194) actionable There is clear action for a vLLM developer to take labels Oct 9, 2025
@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Oct 9, 2025
@vllm-project vllm-project deleted a comment from chatgpt-codex-connector bot Oct 9, 2025
@DarkLight1337 DarkLight1337 requested a review from Isotr0py October 9, 2025 04:38
gemini-code-assist[bot]

This comment was marked as outdated.

Sign in to view

@noooop
Copy link
Collaborator

noooop commented Oct 9, 2025

Since you submitted a PR to fix the nightly tests, I think https://buildkite.com/vllm/ci/builds/33941/steps/canvas?sid=0199c1fa-d5a7-40a2-8f02-b45545380a3b is best fixed here.

7c7d124

pass testing locally

@DarkLight1337
Use atol
4a8e6c0 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) October 9, 2025 05:22
@DarkLight1337
Copy link
Member Author

Now we have another failure, let's fix it in another PR

@vllm-bot vllm-bot merged commit 0f29dca into vllm-project:main Oct 9, 2025
29 of 31 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-tests branch October 9, 2025 06:44
@noooop noooop mentioned this pull request Oct 9, 2025
Merged
5 tasks
845473182 pushed a commit to dsxsteven/vllm_splitPR that referenced this pull request Oct 10, 2025
Merge branch 'loader' of https://github.com/dsxsteven/vllm_splitPR in…
190900b 
…to loader

* 'loader' of https://github.com/dsxsteven/vllm_splitPR: (778 commits)
  [torchao] Add support for ModuleFqnToConfig using regex (vllm-project#26001)
  Add: Support for multiple hidden layers in Eagle3 (vllm-project#26164)
  Enable `RMSNorm` substitution for Transformers backend (vllm-project#26353)
  [Model] Gemma3: Fix GGUF loading and quantization (vllm-project#26189)
  Bump Flashinfer to v0.4.0 (vllm-project#26326)
  Update Dockerfile and install runai-model-streamer[gcs] package (vllm-project#26464)
  [Core] Relax the LoRA  max rank (vllm-project#26461)
  [CI/Build] Fix model nightly tests (vllm-project#26466)
  [Hybrid]: Decouple Kernel Block Size from KV Page Size (vllm-project#24486)
  [Core][KVConnector] Propagate all tokens on resumed preemptions (vllm-project#24926)
  [MM][Doc] Add documentation for configurable mm profiling (vllm-project#26200)
  [Hardware][AMD] Enable FlexAttention backend on ROCm (vllm-project#26439)
  [Bugfix] Incorrect another MM data format in vllm bench throughput (vllm-project#26462)
  [Bugfix] Catch and log invalid token ids in detokenizer #2 (vllm-project#26445)
  [Minor] Change warning->warning_once in preprocess (vllm-project#26455)
  [Bugfix] Set the minimum python version for gpt-oss (vllm-project#26392)
  [Misc] Redact ray runtime env before logging (vllm-project#26302)
  Separate MLAAttention class from Attention (vllm-project#25103)
  [Attention] Register FLASHMLA_SPARSE (vllm-project#26441)
  [Kernels] Modular kernel refactor (vllm-project#24812)
  ...
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 10, 2025
@DarkLight1337 @xuebwang-amd
[CI/Build] Fix model nightly tests (vllm-project#26466)
588c8d8 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Dhruvilbhatt pushed a commit to Dhruvilbhatt/vllm that referenced this pull request Oct 14, 2025
@DarkLight1337 @Dhruvilbhatt
[CI/Build] Fix model nightly tests (vllm-project#26466)
6a84a37 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
@DarkLight1337 @lywa1998
[CI/Build] Fix model nightly tests (vllm-project#26466)
98f14b8 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
@DarkLight1337 @alhridoy
[CI/Build] Fix model nightly tests (vllm-project#26466)
d32fee7 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
@DarkLight1337 @xuebwang-amd
[CI/Build] Fix model nightly tests (vllm-project#26466)
ed9d853 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
@DarkLight1337 @0xrushi
[CI/Build] Fix model nightly tests (vllm-project#26466)
6015d4e 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
@DarkLight1337 @0xrushi
[CI/Build] Fix model nightly tests (vllm-project#26466)
fbe3b85 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@hmellor hmellor Awaiting requested review from hmellor

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/build multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DarkLight1337 @noooop @Isotr0py @vllm-bot