Upgrade Pydantic to v2.12.0 and remove hack for Python 3.13 #26481
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
hmellor
requested review from
ProExpertProg,
WoosukKwon,
houseroad,
mgoin,
robertgshaw2-redhat,
simon-mo,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
|
See if tests pass |
github-actions
bot
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades Pydantic to version 2.12.0, which allows for the removal of a workaround previously needed for Python 3.13 support. The changes correctly update the Pydantic version across various requirements files and remove the now-obsolete hack from vllm/config/utils.py. The dependency updates in the lock file are consistent with the Pydantic upgrade. The changes are correct and well-contained. I have no further comments.
…ject#26481) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: yang926 <yang926@naver.com>
|
note that pydantic v2.12.0 has some issues: https://github.com/pydantic/pydantic/issues?q=is%3Aissue%20state%3Aopen%202.12.0 |
|
It seems that we are not experiencing any issues as all the tests have passed (changing the requirements triggers every test to run). We will update to a patch version as soon as it is available. |
…ject#26481) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…ject#26481) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
…ject#26481) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…ject#26481) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…ject#26481) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…ject#26481) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
…ject#26481) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
…ject#26481) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
4 participants
We can do this now that the new Pydantic version has been released