[Chore]: One pythonic tool parser test uses the wrong parser #26515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue pointed out by Gemini on a separate PR, where the `test_pythonic_tool_parser.py` was accidentally testing against the `llama4_pythonic` parser instead of the `pythonic` parser in one of its tests. Signed-off-by: Ben Browning <bbrownin@redhat.com>
bbrowning
requested review from
DarkLight1337,
NickLucche,
aarnphm,
robertgshaw2-redhat and
simon-mo
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a test case in test_pythonic_tool_parser.py that was using the wrong tool parser (llama4_pythonic instead of pythonic). The change aligns the test with its intended purpose of testing the pythonic tool parser. The fix is straightforward and correct, and I have no further suggestions.
DarkLight1337
approved these changes
Oct 10, 2025
github-actions
bot
added
the
ready
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…oject#26515) Signed-off-by: Ben Browning <bbrownin@redhat.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Dhruvilbhatt
pushed a commit
to Dhruvilbhatt/vllm
that referenced
this pull request
Oct 14, 2025
…oject#26515) Signed-off-by: Ben Browning <bbrownin@redhat.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Oct 16, 2025
…oject#26515) Signed-off-by: Ben Browning <bbrownin@redhat.com> Signed-off-by: bbartels <benjamin@bartels.dev>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…oject#26515) Signed-off-by: Ben Browning <bbrownin@redhat.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…oject#26515) Signed-off-by: Ben Browning <bbrownin@redhat.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…oject#26515) Signed-off-by: Ben Browning <bbrownin@redhat.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…oject#26515) Signed-off-by: Ben Browning <bbrownin@redhat.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…oject#26515) Signed-off-by: Ben Browning <bbrownin@redhat.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…oject#26515) Signed-off-by: Ben Browning <bbrownin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This fixes an issue pointed out by Gemini on a separate PR, where the
test_pythonic_tool_parser.pywas accidentally testing against thellama4_pythonicparser instead of thepythonicparser in one of its tests.Test Plan
Test Result
The test passed before and after this change, but now it's testing the right tool call parser.