-
-
Notifications
You must be signed in to change notification settings - Fork 11k
docs: wrong command in structured_outputs README #26677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
|
Documentation preview: https://vllm--26677.org.readthedocs.build/en/26677/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request corrects a typo in a command within the structured_outputs example's README file. The command incorrectly referred to the executable as structured-output instead of the correct structured-outputs. The change is accurate and fixes the issue, allowing users to run the example command successfully. The change is well-contained and I have no further feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com> Signed-off-by: 1994 <1994@users.noreply.github.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com> Signed-off-by: bbartels <benjamin@bartels.dev>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Purpose
as diff
before this patch
➜ vllm git:(main) vim examples/online_serving/structured_outputs/README.md
➜ vllm git:(main) uvx --from git+https://github.com/vllm-project/vllm#subdirectory=examples/online_serving/structured_outputs
structured-output
Updated https://github.com/vllm-project/vllm (41f3884)
Built examples-online-structured-outputs @ git+https://github.com/vllm-project/vllm@41f3884438c082c4cc2250eb800b8586e1a103d8#subdirectory=examples/o
Installed 17 packages in 25ms
An executable named
structured-outputis not provided by packageexamples-online-structured-outputs.The following executables are available:
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.