Skip to content

Conversation

@kfhfar
Copy link
Contributor

@kfhfar kfhfar commented Oct 13, 2025

Purpose

This is part of #22041 and CI sprint. This is for pruning the Kernel Core tests. Used #22936, #22939 for reference.

Test Plan

pytest tests/kernels/core

Test Result

All tests succeeded or skipped:

Test with Change

platform linux -- Python 3.12.10, pytest-8.3.5, pluggy-1.5.0
rootdir: /home/ubuntu/vllm
configfile: pyproject.toml
plugins: hypothesis-6.131.0, shard-0.1.2, forked-1.6.0, asyncio-0.24.0, cov-6.3.0, mock-3.14.0, buildkite-test-collector-0.1.9, rerunfailures-14.0, schemathesis-3.39.15, subtests-0.14.1, hydra-core-1.3.2, timeout-2.3.1, anyio-4.6.2.post1
asyncio: mode=Mode.STRICT, default_loop_scope=None
collected 3785 items                                                                                                                                                                                                                                                                                        
Running 3785 items in this shard

.venv/lib/python3.12/site-packages/schemathesis/generation/coverage.py:305
  /home/ubuntu/vllm/.venv/lib/python3.12/site-packages/schemathesis/generation/coverage.py:305: DeprecationWarning: jsonschema.exceptions.RefResolutionError is deprecated as of version 4.18.0. If you wish to catch potential reference resolution errors, directly catch referencing.exceptions.Unresolvable.
    ref_error: type[Exception] = jsonschema.RefResolutionError,

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================== 3769 passed, 16 skipped, 1 warning in 2308.23s (0:38:28) =========================

Test with Current Production Code

platform linux -- Python 3.12.10, pytest-8.3.5, pluggy-1.5.0
rootdir: /home/ubuntu/vllm
configfile: pyproject.toml
plugins: hypothesis-6.131.0, shard-0.1.2, forked-1.6.0, asyncio-0.24.0, cov-6.3.0, mock-3.14.0, buildkite-test-collector-0.1.9, rerunfailures-14.0, schemathesis-3.39.15, subtests-0.14.1, hydra-core-1.3.2, timeout-2.3.1, anyio-4.6.2.post1
asyncio: mode=Mode.STRICT, default_loop_scope=None
collected 6118 items                                                                                      
Running 6118 items in this shard

======================== 6102 passed, 16 skipped, 1 warning in 5047.41s (1:24:07) =========================

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@kfhfar kfhfar marked this pull request as ready for review October 13, 2025 19:29
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

@mgoin
Copy link
Member

mgoin commented Oct 13, 2025

@kfhfar How many tests does this prune from the total count for this directory? It seems like these are already fast tests, so I'm not sure I see the purpose of focusing on them. Please include some metrics like in my PRs that you referenced

Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
@kfhfar kfhfar force-pushed the kfhfar/kernel-core-prune branch from 0d27270 to b659613 Compare October 13, 2025 21:52
@mgoin mgoin added ready ONLY add when PR is ready to merge/full CI is needed ci/build labels Oct 13, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That is more substantial of a prune than I thought it would be, thank you

@mgoin mgoin enabled auto-merge (squash) October 13, 2025 22:09
@mgoin mgoin merged commit fa96fb9 into vllm-project:main Oct 13, 2025
18 checks passed
1994 pushed a commit to 1994/vllm that referenced this pull request Oct 14, 2025
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
Signed-off-by: 1994 <1994@users.noreply.github.com>
Dhruvilbhatt pushed a commit to Dhruvilbhatt/vllm that referenced this pull request Oct 14, 2025
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
bbartels pushed a commit to bbartels/vllm that referenced this pull request Oct 16, 2025
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
Signed-off-by: bbartels <benjamin@bartels.dev>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
Zhathw pushed a commit to Zhathw/vllm that referenced this pull request Nov 12, 2025
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants