-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Pruning kernel Core Tests #26727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pruning kernel Core Tests #26727
Conversation
yewentao256
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
|
@kfhfar How many tests does this prune from the total count for this directory? It seems like these are already fast tests, so I'm not sure I see the purpose of focusing on them. Please include some metrics like in my PRs that you referenced |
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
0d27270 to
b659613
Compare
mgoin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! That is more substantial of a prune than I thought it would be, thank you
Signed-off-by: Fardin Hoque <kfhfar@amazon.com> Signed-off-by: 1994 <1994@users.noreply.github.com>
Signed-off-by: Fardin Hoque <kfhfar@amazon.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
Signed-off-by: Fardin Hoque <kfhfar@amazon.com> Signed-off-by: bbartels <benjamin@bartels.dev>
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
Signed-off-by: Fardin Hoque <kfhfar@amazon.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: Fardin Hoque <kfhfar@amazon.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Signed-off-by: Fardin Hoque <kfhfar@amazon.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Signed-off-by: Fardin Hoque <kfhfar@amazon.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
Signed-off-by: Fardin Hoque <kfhfar@amazon.com>
Purpose
This is part of #22041 and CI sprint. This is for pruning the Kernel Core tests. Used #22936, #22939 for reference.
Test Plan
pytest tests/kernels/coreTest Result
All tests succeeded or skipped:
Test with Change
Test with Current Production Code
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.