Skip to content

[Bugfix][Core] running queue index leakage exception #26754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

[Bugfix][Core] running queue index leakage exception #26754

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fcf1fc
index leakage exception
CLFutureX Oct 14, 2025
6a183d0
Merge branch 'main' into fix_running_index_out
njhill Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vllm/v1/core/sched/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ def schedule(self) -> SchedulerOutput:
token_budget += num_scheduled_tokens[preempted_req.request_id]
req_to_new_blocks.pop(preempted_req.request_id)
num_scheduled_tokens.pop(preempted_req.request_id)
req_index -= 1
Copy link
Member

@njhill njhill Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @CLFutureX and sorry for not getting to it sooner!

I think whether we decrement req_index here should depend on whether the index of the preempted request is less than req_index?

Copy link
Member

@njhill njhill Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nevermind, I see that it will only be in scheduled_running_reqs iff this is the case, so I think this looks correct.

else:
preempted_req = self.running.pop()

Expand Down