Skip to content

Conversation

@ryanli
Copy link
Contributor

@ryanli ryanli commented Oct 14, 2025

Purpose

Rectify the name of the default scheduler which has been moved, fixing #26756.

Test Plan

To build an application directly using AsyncLLM using this updated build with default SchedulerConfig.

Test Result

The application starts successfully:

(EngineCore_DP0 pid=64) INFO 10-14 03:58:42 [core.py:210] init engine (profile, create kv cache, warmup model) took 44.50 seconds
INFO 10-14 03:58:55 [loggers.py:147] Engine 000: vllm cache_config_info with initialization after num_gpu_blocks is: 16866

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the default scheduler class path in vllm/config/scheduler.py, which is a necessary fix to address an application startup failure. While the change is correct for the file modified, it has an unintended side effect in vllm/engine/arg_utils.py that could break configurations for users who explicitly specify the old scheduler path. I have left a detailed comment explaining the issue and a suggested fix. Addressing this backward compatibility issue would make this PR more complete.

Signed-off-by: Ryan Li <ryanli@ryanli.org>
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ryanli

@njhill njhill linked an issue Oct 14, 2025 that may be closed by this pull request
1 task
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) October 14, 2025 05:01
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 14, 2025
@DarkLight1337 DarkLight1337 merged commit 481545b into vllm-project:main Oct 14, 2025
49 checks passed
Dhruvilbhatt pushed a commit to Dhruvilbhatt/vllm that referenced this pull request Oct 14, 2025
…#26758)

Signed-off-by: Ryan Li <ryanli@ryanli.org>
Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
bbartels pushed a commit to bbartels/vllm that referenced this pull request Oct 16, 2025
…#26758)

Signed-off-by: Ryan Li <ryanli@ryanli.org>
Signed-off-by: bbartels <benjamin@bartels.dev>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
…#26758)

Signed-off-by: Ryan Li <ryanli@ryanli.org>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Oct 24, 2025
…#26758)

Signed-off-by: Ryan Li <ryanli@ryanli.org>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
…#26758)

Signed-off-by: Ryan Li <ryanli@ryanli.org>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
…#26758)

Signed-off-by: Ryan Li <ryanli@ryanli.org>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Zhathw pushed a commit to Zhathw/vllm that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ModuleNotFoundError: No module named 'vllm.core'

3 participants