-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Kernel][MoE] Add MoE tunings for GLM 4.6-FP8 and GLM 4.5 Air on NVidia B200 #26818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds new MoE kernel tuning configurations for GLM 4.6-FP8 and GLM 4.5 Air on NVIDIA B200 GPUs. The configurations for GLM 4.6-FP8 (tp=4) and GLM 4.5 Air (tp=2) appear consistent with the benchmark commands provided. However, I've identified a significant inconsistency in the configuration file for GLM 4.5 Air with tp=4, which may be misnamed or generated incorrectly. This could impact performance and needs to be addressed.
| @@ -0,0 +1,147 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be an inconsistency in this configuration file's name and content when compared with the benchmark command from the pull request description for zai-org/GLM-4.5-Air with tp=4.
Here's a breakdown of the inconsistencies, assuming GLM-4.5-Air has 64 experts:
- Number of Experts (
E): Withtp=4and expert parallelism enabled, each rank should handle64 / 4 = 16experts. TheEparameter in the filename, which seems to represent the number of local experts based on other files in this PR, should be16, but it is64. For comparison, thetp=2configuration for the same model correctly usesE=32(64 / 2 = 32). - Intermediate Size (
N): The intermediate sizeNis1408in this file, which is the same as in thetp=2configuration. Since the intermediate size is typically sharded across tensor parallel ranks, the value ofNshould be different fortp=2andtp=4. IfN=1408is correct fortp=2(implying a total intermediate size of1408 * 2 = 2816), then fortp=4it should be2816 / 4 = 704.
This suggests the file might be misnamed or generated from an incorrect configuration, which could lead to suboptimal performance or errors. Please double-check how this file was generated.
mgoin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any benchmarks showing that these configs improve performance?
|
yes though the improvement is only very slight: Without tuning: with tuning: This is for glm-4.6-fp8, I seem to have lost my results for -Air (and the machine I have is currently in use) using the following config |
…ia B200 (vllm-project#26818) Signed-off-by: bbartels <benjamin@bartels.dev>
…ia B200 (vllm-project#26818) Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…ia B200 (vllm-project#26818) Signed-off-by: xuebwang-amd <xuebwang@amd.com>
…ia B200 (vllm-project#26818) Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
…ia B200 (vllm-project#26818) Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Purpose
See title.
I ran the following:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.