Skip to content

[Bugfix] skip cuda graph for drafter when running with eager #26821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 21, 2025
Merged

[Bugfix] skip cuda graph for drafter when running with eager #26821

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29268b0
skip cuda graph for drafter when running with eager
benchislett Oct 14, 2025
ab806f0
Merge branch 'main' into bugfix-eagle-with-eager
benchislett Oct 15, 2025
0c0b556
Merge branch 'main' into bugfix-eagle-with-eager
benchislett Oct 15, 2025
db7c7d8
Merge branch 'main' into bugfix-eagle-with-eager
benchislett Oct 21, 2025
a638095
Merge branch 'main' into bugfix-eagle-with-eager
benchislett Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vllm/v1/worker/gpu_model_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3482,7 +3482,10 @@ def _dummy_run(

if self.speculative_config and self.speculative_config.use_eagle():
assert isinstance(self.drafter, EagleProposer)
use_cudagraphs = cudagraph_runtime_mode == CUDAGraphMode.PIECEWISE
use_cudagraphs = (
cudagraph_runtime_mode == CUDAGraphMode.PIECEWISE
and not self.speculative_config.enforce_eager
)
self.drafter.dummy_run(num_tokens, use_cudagraphs=use_cudagraphs)

# This is necessary to avoid blocking DP.
Expand Down