-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[CI/Build][Intel] Enable performance benchmarks for Intel Gaudi 3 #26919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/Build][Intel] Enable performance benchmarks for Intel Gaudi 3 #26919
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enables performance benchmarks for Intel Gaudi 3 by adding a new Dockerfile, updating the benchmark script to detect Gaudi devices, and including new test configurations. The changes are well-structured and mostly look good. I've found one potential bug in the benchmark script where a command to check memory usage might fail due to incorrect parsing of the command output. This could prevent the script from correctly waiting for resources to be freed. My review includes a specific suggestion to fix this issue.
.buildkite/nightly-benchmarks/scripts/run-performance-benchmarks.sh
Outdated
Show resolved
Hide resolved
41c2a72 to
2e2bcce
Compare
💡 Codex ReviewLines 44 to 56 in 41c2a72
The vllm/.buildkite/nightly-benchmarks/scripts/run-performance-benchmarks.sh Lines 140 to 151 in 41c2a72
In the new HL‑SMI branch of ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. |
411b5f2 to
93bd003
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
b87e940 to
c63a5b0
Compare
Signed-off-by: jakub-sochacki <jakub.sochacki@wp.pl>
Signed-off-by: jakub-sochacki <jakub.sochacki@wp.pl>
Signed-off-by: jakub-sochacki <jakub.sochacki@wp.pl>
Signed-off-by: jakub-sochacki <jakub.sochacki@wp.pl>
Signed-off-by: jakub-sochacki <jakub.sochacki@wp.pl>
Signed-off-by: jakub-sochacki <jakub.sochacki@wp.pl>
Signed-off-by: jakub-sochacki <jakub.sochacki@wp.pl>
Signed-off-by: jakub-sochacki <jakub.sochacki@wp.pl>
Signed-off-by: jakub-sochacki <jakub.sochacki@wp.pl>
Signed-off-by: jakub-sochacki <jakub.sochacki@wp.pl>
c63a5b0 to
135458f
Compare
|
@DarkLight1337 @khluu @jikunshang , may you help to review and merge, meanwhile, there are other two PRs related to this one |
…lm-project#26919) Signed-off-by: jakub-sochacki <jakub.sochacki@wp.pl>
…lm-project#26919) Signed-off-by: jakub-sochacki <jakub.sochacki@wp.pl>
Purpose
Enable Intel Gaudi 3 Accelerator for vLLM Benchmark suite for performance benchmarking.
Test Plan
Models tested: Llama 3.1-8B (TP1), Llama 3.1-70B (TP4), Mixtral 8x7B (TP2)
Scenarios: throughput, latency and serving
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.