[bugfix] Qwen3-VL fix video incorrect timestamp calculations while do_sample_frames=True #27104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug where video timestamps were incorrectly calculated when frame sampling was enabled. The change introduces a new sampled_fps variable to avoid overwriting the original video_fps, ensuring the correct value is used for timestamp calculations. The fix is well-targeted and effectively resolves the issue.
Isotr0py
approved these changes
Oct 17, 2025
github-actions
bot
added
the
ready
This was referenced Oct 20, 2025
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…_sample_frames=True (vllm-project#27104) Co-authored-by: 松灵 <wpf272043@alibaba-inc.com>
albertoperdomo2
pushed a commit
to albertoperdomo2/vllm
that referenced
this pull request
Oct 23, 2025
…_sample_frames=True (vllm-project#27104) Co-authored-by: 松灵 <wpf272043@alibaba-inc.com> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…_sample_frames=True (vllm-project#27104) Co-authored-by: 松灵 <wpf272043@alibaba-inc.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…_sample_frames=True (vllm-project#27104) Co-authored-by: 松灵 <wpf272043@alibaba-inc.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…_sample_frames=True (vllm-project#27104) Co-authored-by: 松灵 <wpf272043@alibaba-inc.com> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…_sample_frames=True (vllm-project#27104) Co-authored-by: 松灵 <wpf272043@alibaba-inc.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…_sample_frames=True (vllm-project#27104) Co-authored-by: 松灵 <wpf272043@alibaba-inc.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
This was referenced Oct 31, 2025
ilmarkov
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 7, 2025
…_sample_frames=True (vllm-project#27104) Co-authored-by: 松灵 <wpf272043@alibaba-inc.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…_sample_frames=True (vllm-project#27104) Co-authored-by: 松灵 <wpf272043@alibaba-inc.com>
Zhathw
pushed a commit
to Zhathw/vllm
that referenced
this pull request
Nov 12, 2025
…_sample_frames=True (vllm-project#27104) Co-authored-by: 松灵 <wpf272043@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code overwrites
video_fpswithsampled_fps, which causes incorrect timestamp calculations.@ywang96 Hey bro, could you please help review this? Thanks!