[Chore] Remove unused PolyNorm layer
#27110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Isotr0py
requested review from
WoosukKwon,
mgoin,
tlrmchlsmth and
yewentao256
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes the unused PolyNorm layer, including its definition, tests, and benchmarks. This is a good cleanup step.
However, the cleanup appears to be incomplete. The helper functions poly_norm in vllm/model_executor/layers/layernorm.py and vllm/_custom_ops.py seem to be orphaned by this change, as they were only used by the PolyNorm layer. For a complete cleanup, these functions and the underlying C++ kernel (torch.ops._C.poly_norm) should also be removed. Since these functions are not in the current diff, I am noting this here for you to consider.
mgoin
approved these changes
Oct 17, 2025
github-actions
bot
added
the
ready
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
zhuohan123
approved these changes
Oct 17, 2025
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
adabeyta
pushed a commit
to adabeyta/vllm
that referenced
this pull request
Oct 20, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
WyldeCat
added a commit
to MotifTechnologies/vllm
that referenced
this pull request
Oct 22, 2025
This reverts commit 3125d79.
WyldeCat
added a commit
to MotifTechnologies/vllm
that referenced
this pull request
Oct 23, 2025
This reverts commit 3125d79. Signed-off-by: WyldeCat <skan1543@gmail.com>
5 tasks
albertoperdomo2
pushed a commit
to albertoperdomo2/vllm
that referenced
this pull request
Oct 23, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: xuebwang-amd <xuebwang@amd.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
PolyNormbecause there are no models using it anymore after v0 deprecationTest Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.