-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[Chore] Separate out vllm.utils.network_utils
#27164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…vllm into split-network-utils Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com>
|
Documentation preview: https://vllm--27164.org.readthedocs.build/en/27164/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a good refactoring effort to separate network utility functions into their own module, vllm.utils.network_utils. The changes primarily involve moving code and updating import statements across the codebase, which improves modularity and maintainability. I've identified a potential resource leak in the get_ip function and provided a suggestion to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! See if the tests pass
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com>
Head branch was pushed to by a user without write access
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors network utility functions from vllm.utils into a new vllm.utils.network_utils module, which is a good step for code organization. However, the implementation for backward compatibility is incomplete, which could introduce breaking changes for users importing the moved functions from their old location. My review includes a critical fix to ensure a smooth transition with proper deprecation warnings.
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com>
…vllm into split-network-utils
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com> Co-authored-by: iAmir97 <Amir.balwel@embeddedllm.com>
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com> Co-authored-by: iAmir97 <Amir.balwel@embeddedllm.com>
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com> Co-authored-by: iAmir97 <Amir.balwel@embeddedllm.com> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com> Co-authored-by: iAmir97 <Amir.balwel@embeddedllm.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com> Co-authored-by: iAmir97 <Amir.balwel@embeddedllm.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Part of #26900
vllm.utils.close_sockets -> vllm.utils.network_utils.close_socketsvllm.utils.get_ip -> vllm.utils.network_utils.get_ipvllm.utils.test_loopback_bind -> vllm.utils.network_utils.test_loopback_bindvllm.utils.get_loopback_ip -> vllm.utils.network_utils.get_loopback_ipvllm.utils.is_valid_ipv6_address -> vllm.utils.network_utils.is_valid_ipv6_addressvllm.utils.split_host_port -> vllm.utils.network_utils.split_host_portvllm.utils.join_host_port -> vllm.utils.network_utils.join_host_portvllm.utils.get_distributed_init_method -> vllm.utils.network_utils.get_distributed_init_methodvllm.utils.get_tcp_uri -> vllm.utils.network_utils.get_tcp_urivllm.utils.get_open_zmq_ipc_path -> vllm.utils.network_utils.get_open_zmq_ipc_pathvllm.utils.get_open_zmq_inproc_path -> vllm.utils.network_utils.get_open_zmq_inproc_pathvllm.utils.get_open_port -> vllm.utils.network_utils.get_open_portvllm.utils.get_open_ports_list -> vllm.utils.network_utils.get_open_ports_listvllm.utils._get_open_port -> vllm.utils.network_utils._get_open_portvllm.utils.find_process_using_port -> vllm.utils.network_utils.find_process_using_portvllm.utils.split_zmq_path -> vllm.utils.network_utils.split_zmq_pathvllm.utils.make_zmq_path -> vllm.utils.network_utils.make_zmq_pathvllm.utils.make_zmq_socket -> vllm.utils.network_utils.make_zmq_socketvllm.utils.zmq_socket_ctx -> vllm.utils.network_utils.zmq_socket_ctxPurpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.