Skip to content

Conversation

@iAmir97
Copy link
Contributor

@iAmir97 iAmir97 commented Oct 19, 2025

Part of #26900

  • vllm.utils.close_sockets -> vllm.utils.network_utils.close_sockets
  • vllm.utils.get_ip -> vllm.utils.network_utils.get_ip
  • vllm.utils.test_loopback_bind -> vllm.utils.network_utils.test_loopback_bind
  • vllm.utils.get_loopback_ip -> vllm.utils.network_utils.get_loopback_ip
  • vllm.utils.is_valid_ipv6_address -> vllm.utils.network_utils.is_valid_ipv6_address
  • vllm.utils.split_host_port -> vllm.utils.network_utils.split_host_port
  • vllm.utils.join_host_port -> vllm.utils.network_utils.join_host_port
  • vllm.utils.get_distributed_init_method -> vllm.utils.network_utils.get_distributed_init_method
  • vllm.utils.get_tcp_uri -> vllm.utils.network_utils.get_tcp_uri
  • vllm.utils.get_open_zmq_ipc_path -> vllm.utils.network_utils.get_open_zmq_ipc_path
  • vllm.utils.get_open_zmq_inproc_path -> vllm.utils.network_utils.get_open_zmq_inproc_path
  • vllm.utils.get_open_port -> vllm.utils.network_utils.get_open_port
  • vllm.utils.get_open_ports_list -> vllm.utils.network_utils.get_open_ports_list
  • vllm.utils._get_open_port -> vllm.utils.network_utils._get_open_port
  • vllm.utils.find_process_using_port -> vllm.utils.network_utils.find_process_using_port
  • vllm.utils.split_zmq_path -> vllm.utils.network_utils.split_zmq_path
  • vllm.utils.make_zmq_path -> vllm.utils.network_utils.make_zmq_path
  • vllm.utils.make_zmq_socket -> vllm.utils.network_utils.make_zmq_socket
  • vllm.utils.zmq_socket_ctx -> vllm.utils.network_utils.zmq_socket_ctx

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

iAmir97 added 2 commits October 19, 2025 11:46
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com>
…vllm into split-network-utils

Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com>
@mergify
Copy link

mergify bot commented Oct 19, 2025

Documentation preview: https://vllm--27164.org.readthedocs.build/en/27164/

@mergify mergify bot added documentation Improvements or additions to documentation frontend multi-modality Related to multi-modality (#4194) v1 labels Oct 19, 2025
@mergify mergify bot added the kv-connector label Oct 19, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a good refactoring effort to separate network utility functions into their own module, vllm.utils.network_utils. The changes primarily involve moving code and updating import statements across the codebase, which improves modularity and maintainability. I've identified a potential resource leak in the get_ip function and provided a suggestion to fix it.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See if the tests pass

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) October 19, 2025 04:48
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 19, 2025
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com>
auto-merge was automatically disabled October 19, 2025 06:02

Head branch was pushed to by a user without write access

@iAmir97
Copy link
Contributor Author

iAmir97 commented Oct 19, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors network utility functions from vllm.utils into a new vllm.utils.network_utils module, which is a good step for code organization. However, the implementation for backward compatibility is incomplete, which could introduce breaking changes for users importing the moved functions from their old location. My review includes a critical fix to ensure a smooth transition with proper deprecation warnings.

@vllm-bot vllm-bot merged commit 7a6c8c3 into vllm-project:main Oct 19, 2025
56 of 58 checks passed
@DarkLight1337 DarkLight1337 deleted the split-network-utils branch October 19, 2025 10:06
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com>
Co-authored-by: iAmir97 <Amir.balwel@embeddedllm.com>
adabeyta pushed a commit to adabeyta/vllm that referenced this pull request Oct 20, 2025
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com>
Co-authored-by: iAmir97 <Amir.balwel@embeddedllm.com>
albertoperdomo2 pushed a commit to albertoperdomo2/vllm that referenced this pull request Oct 23, 2025
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com>
Co-authored-by: iAmir97 <Amir.balwel@embeddedllm.com>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com>
Co-authored-by: iAmir97 <Amir.balwel@embeddedllm.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: iAmir97 <Amir.balwel@embeddedllm.com>
Co-authored-by: iAmir97 <Amir.balwel@embeddedllm.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation frontend kv-connector multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants