Fix typo in ValueError message: use kv_role instead of kv_disagg_role
#27166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ole` Correct field name in ValueError message to match actual parameter kv_role. Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
hyongtao-code
requested review from
ProExpertProg,
WoosukKwon,
hmellor,
houseroad,
mgoin,
robertgshaw2-redhat,
simon-mo,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a typo in a ValueError message within KVTransferConfig. The parameter name was updated from the incorrect kv_disagg_role to the correct kv_role, which will improve clarity for users during configuration. The change is accurate and I did not find any high or critical severity issues.
yewentao256
approved these changes
Oct 19, 2025
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…ole` (vllm-project#27166) Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
adabeyta
pushed a commit
to adabeyta/vllm
that referenced
this pull request
Oct 20, 2025
…ole` (vllm-project#27166) Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
albertoperdomo2
pushed a commit
to albertoperdomo2/vllm
that referenced
this pull request
Oct 23, 2025
…ole` (vllm-project#27166) Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…ole` (vllm-project#27166) Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…ole` (vllm-project#27166) Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
ilmarkov
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 7, 2025
…ole` (vllm-project#27166) Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…ole` (vllm-project#27166) Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
Zhathw
pushed a commit
to Zhathw/vllm
that referenced
this pull request
Nov 12, 2025
…ole` (vllm-project#27166) Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Correct field name in ValueError message to match the actual parameter kv_role.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.