-
-
Notifications
You must be signed in to change notification settings - Fork 11.1k
[Benchmark] Add plot utility for parameter sweep #27168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
b5eac52
[Benchmark] Add plot utility for parameter sweep
DarkLight1337 7f93c36
Update
DarkLight1337 d52e9b9
Add log plot
DarkLight1337 2f96852
Fix multifigure
DarkLight1337 fcf156b
Update command
DarkLight1337 ad14a53
Add title
DarkLight1337 08fab86
Support file prefix
DarkLight1337 bc04f30
Separate
DarkLight1337 1e13493
Improve separation
DarkLight1337 c848b10
Set by directory, not prefix
DarkLight1337 f7f36f2
Fix
DarkLight1337 c6cb78a
Plot in parallel
DarkLight1337 4cc5e90
Clean up
DarkLight1337 4af1e1a
Don't silently fail
DarkLight1337 7d82607
Pretty
DarkLight1337 8150f44
Fix nested
DarkLight1337 6ace5b2
Raise error if no data found
DarkLight1337 b3eb7cd
Show the problematic data item
DarkLight1337 8154e08
Convert to string first
DarkLight1337 d9fcb09
Be more clear
DarkLight1337 9c0e9fa
Use seaborn grid
DarkLight1337 f1810cc
Clean up
DarkLight1337 dac464b
Clean
DarkLight1337 73c911b
TODO
DarkLight1337 eef9c40
Clean
DarkLight1337 aa96151
Generalized filter and binning
DarkLight1337 0b98496
Remove old script
DarkLight1337 94c94c4
Merge branch 'main' into benchmark-sweep
DarkLight1337 ae9d021
Update import
DarkLight1337 beb3854
Clean up
DarkLight1337 5f36c62
Fix
DarkLight1337 8fbfd49
Simplify
DarkLight1337 daee7a8
Fix legend
DarkLight1337 b9e08ff
Fix
DarkLight1337 ad4149b
Reword
DarkLight1337 c5eaf78
Fix
DarkLight1337 c7426c2
Reword
DarkLight1337 49deaab
Reorder
DarkLight1337 0a4eb36
Informative error
DarkLight1337 8afa4d3
Separate out SLA tuner
DarkLight1337 3fa0d4c
Update
DarkLight1337 a3d1095
Improve error message
DarkLight1337 a4adbda
Allow strings
DarkLight1337 6357b84
Fix
DarkLight1337 f750fc5
Fix
DarkLight1337 2d856ff
Ordering
DarkLight1337 e6d4c72
Don't split
DarkLight1337 46d9f19
Remove unnecessary quotes
DarkLight1337 b95d706
Merge branch 'main' into benchmark-sweep
DarkLight1337 ceabbc8
Update with benchmark overrides as well
DarkLight1337 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use a vllm serve api address, we should how to config?
Maybe we should add a
--serve-hostparam, user can set a vllm online server, then this--serve-paramsparam can be invalid.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can set the server's host via
--serve-cmd. And for resetting the server cache after each benchmark run, you can use--after-bench-cmd.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you mean that the benchmark should not be responsible for launching the server, you can just use a dummy command that sleeps infinitely and adjust
--bench-cmdto access the real server. Of course, you should also set--after-bench-cmdin this case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, maybe i not need set
--serve-cmdparam, use--bench-cmdparam to setvllm bench serve --model meta-llama/Llama-2-7b-chat-hf --backend openaiis enough.