-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[ROCm][MLA] Support block-size > 1 for AITER MLA backend #27224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
274eee8
support block-size > 1 for mla by remapping block table
ganyi1996ppo 54bc1bb
resolve comments
ganyi1996ppo da472d6
fix ci
ganyi1996ppo 0cfe8c9
Merge branch 'main' into ganyi/mla_wider_block_size
wuhuikx 4559eee
Merge branch 'main' into ganyi/mla_wider_block_size
ganyi1996ppo df564c0
Merge branch 'main' into ganyi/mla_wider_block_size
ganyi1996ppo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After expanding each block table entry into per-token indices, the code still derives
paged_kv_last_page_lenfrom the originalpage_size(seq_lens % page_size, falling back topage_size). Once the remapping is done, each entry represents a single token, so the last-page length for any non-empty request should always be1. Keeping the old computation causes the decode kernel to believe that the final page containspage_sizetokens (e.g. 128) and it will read that many elements starting from the last token’s index, potentially stepping past the valid token range whenblock_size > 1. This defeats the goal of supporting larger block sizes and can lead to out-of-bounds accesses or garbage attention results for any request longer than one token.Useful? React with 👍 / 👎.