-
-
Notifications
You must be signed in to change notification settings - Fork 11k
[docs] Update v1 metrics design doc #27332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update v1 metrics design doc #27332
Conversation
Signed-off-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: atalhens <sneh.lata@nutanix.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
|
Documentation preview: https://vllm--27332.org.readthedocs.build/en/27332/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a valuable update to the metrics design document, bringing it in line with the V1 engine's capabilities. The changes are well-executed, replacing outdated v0 information with a clear and descriptive list of V1 metrics. The restructuring of the document and the consistent use of historical terminology improve readability and context. The move to shorthand links for PRs and issues is also a nice touch for maintainability. Overall, these changes make the documentation more accurate and useful for developers and users working with vLLM's metrics.
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating
Signed-off-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com> Signed-off-by: atalhens <sneh.lata@nutanix.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Co-authored-by: atalhens <sneh.lata@nutanix.com>
Signed-off-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com> Signed-off-by: atalhens <sneh.lata@nutanix.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Co-authored-by: atalhens <sneh.lata@nutanix.com> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
Signed-off-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com> Signed-off-by: atalhens <sneh.lata@nutanix.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Co-authored-by: atalhens <sneh.lata@nutanix.com>
Signed-off-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com> Signed-off-by: atalhens <sneh.lata@nutanix.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Co-authored-by: atalhens <sneh.lata@nutanix.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Signed-off-by: Simon Mo <simon.mo@hey.com> Signed-off-by: Mark McLoughlin <markmc@redhat.com> Signed-off-by: atalhens <sneh.lata@nutanix.com> Co-authored-by: Simon Mo <simon.mo@hey.com> Co-authored-by: atalhens <sneh.lata@nutanix.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
Fixes #27298
With this caveat:
Co-authored by @simon-mo in #26311 and @atalhens in #27301