[Chore] Remove duplicate has_ functions in vllm.utils
#27372
Conversation
Signed-off-by: Jonathan <chenleejonathan@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes several duplicated has_* helper functions from vllm/utils/__init__.py. These functions, which check for the availability of optional packages like pplx_kernels and deep_gemm, are already present in vllm.utils.import_utils. By removing the redundant definitions and the associated unused importlib.util import, this change improves code maintainability and reduces duplication. The changes are correct and well-contained.
Signed-off-by: Jonathan <chenleejonathan@gmail.com>
…vllm into remove-extra-import
|
Hi @jonathanc-n ，Sorry about that! This is my mistake. |
github-actions
bot
added
the
ready
…#27372) Signed-off-by: Jonathan <chenleejonathan@gmail.com>
…#27372) Signed-off-by: Jonathan <chenleejonathan@gmail.com> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
…o step_forward * 'step_forward' of https://github.com/raindaywhu/vllm: (148 commits) [Model] Add MoE support for NemotronH (vllm-project#25863) [Metrics] [KVConnector] Add connector prefix cache hit rate stats (vllm-project#26245) [CI] Reorganize entrypoints tests (vllm-project#27403) add SLA information into comparison graph for vLLM Benchmark Suite (vllm-project#25525) [CI/Build] Fix AMD CI: test_cpu_gpu.py (vllm-project#27388) [Bugfix] Fix args settings for guided decoding args (vllm-project#27375) [CI/Build] Fix Prithvi plugin test (vllm-project#27393) [Chore] Remove duplicate `has_` functions in vllm.utils (vllm-project#27372) [Model] Add num_cached_tokens for PoolingRequestOutput (vllm-project#27378) [V1][spec decode] return logprobs for spec decoding (vllm-project#26060) [CORE] Support Prefix Caching with Prompt Embeds (vllm-project#27219) [Bugfix][Core] running queue index leakage exception (vllm-project#26754) [Bugfix] Fix incorrect kv cache metrics in grafana.json (vllm-project#27133) [Bugfix] Fix SLA tuner initialization (vllm-project#27355) [Bugfix] Fix deepseek-ocr multi-image inference and add `merge_by_field_config=True` with tensor schema support (vllm-project#27361) [MLA] Bump FlashMLA (vllm-project#27354) [Chore] Separate out system utilities from vllm.utils (vllm-project#27201) [BugFix] bugfix for Flash Attention MLA with full cuda graph IMA following pr-25490 (vllm-project#27128) [Feature] publisher default set zmq in kv_event config (vllm-project#26915) [Prefix Cache] Use LoRA name for consistent KV-cache block hashing (vllm-project#27211) ...
…#27372) Signed-off-by: Jonathan <chenleejonathan@gmail.com>
…#27372) Signed-off-by: Jonathan <chenleejonathan@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
…#27372) Signed-off-by: Jonathan <chenleejonathan@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
3 participants
Purpose
Part of #26900
#27201 seems to have accidentally the
has_functions again. This is just to remove the duplicate functions.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.