Fix test named tool use #27458
Merged
Fix test named tool use #27458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
chaunceyjiang
requested review from
DarkLight1337,
NickLucche,
aarnphm,
robertgshaw2-redhat and
simon-mo
as code owners
chaunceyjiang
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix test_named_tool_use by making it more deterministic with temperature=0.0 and modifying a user prompt. While the intent is clear, there is a critical issue in the construction of the user prompt that will likely lead to test failures. A space is missing between two concatenated strings, which will create a malformed prompt for the model. My review provides a specific code suggestion to correct this.
tests/entrypoints/openai/test_completion_with_function_calling.py
Outdated
Show resolved
Hide resolved
tests/entrypoints/openai/test_completion_with_function_calling.py
Outdated
Show resolved
Hide resolved
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
chaunceyjiang
force-pushed
the
fix_test_named_tool_use
branch
from
f9e97c1 to
d1ee9b8
Compare
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Collaborator
Author
|
/cc @DarkLight1337 PTAL |
DarkLight1337
approved these changes
Oct 24, 2025
Member
|
Thanks for fixing! |
atalhens
pushed a commit
to atalhens/vllm
that referenced
this pull request
Oct 24, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
kingsmad
pushed a commit
to kingsmad/vllm
that referenced
this pull request
Oct 25, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
rohin-garg
pushed a commit
to rohin-garg/vllm
that referenced
this pull request
Oct 25, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
ilmarkov
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 7, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
fix test_named_tool_use
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.